Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@html-eslint/element-newline] skip option does not work with nested tags #160

Closed
yeonjuan opened this issue Nov 20, 2023 · 0 comments · Fixed by #161
Closed

[@html-eslint/element-newline] skip option does not work with nested tags #160

yeonjuan opened this issue Nov 20, 2023 · 0 comments · Fixed by #161
Labels
bug Something isn't working

Comments

@yeonjuan
Copy link
Owner

html

<!DOCTYPE html>
<html>
    <head>
    </head>
    <body>
     	 <div><li> foo </li><div></div>
        </div>
    </body>
</html>

.eslintrc.json

{
  "rules": {
    "@html-eslint/element-newline": ["error", {"skip":["div"]}]
  }
}

Expected Result

No lint error

Actual Result

Lint error, the rule's skip options does not work when tags in skip are nested.

6:6 - There should be a linebreak after
@yeonjuan yeonjuan added the bug Something isn't working label Nov 20, 2023
@yeonjuan yeonjuan changed the title @html-eslint/element-newline skip option does not work with nested tags [@html-eslint/element-newline] skip option does not work with nested tags Nov 20, 2023
yeonjuan added a commit that referenced this issue Nov 22, 2023
@yeonjuan
fix: make skip options handle nested tags (fixes #160)
5774fd8
@yeonjuan yeonjuan mentioned this issue Nov 22, 2023
Merged
yeonjuan added a commit that referenced this issue Nov 22, 2023
@yeonjuan
fix: make skip options handle nested tags (fixes #160) (#161)
221b048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make skip options handle nested tags (fixes #160) yeonjuan/html-eslint
1 participant
@yeonjuan