feat: New rule to disallow certain attribute values #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjuan
requested changes
Oct 12, 2023
There was a problem hiding this comment.
@Adam-Gillespie345 Thanks for your contribution! I left some reviews.
packages/eslint-plugin/tests/rules/no-restricted-attr-values.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: YeonJuan <yeonjuan93@naver.com>
| @@ -21,7 +21,7 @@ | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "cspell": "^6.19.2", | |||
| "eslint": "^7.14.0", | |||
| "eslint": "^7.32.0", | |||
There was a problem hiding this comment.
Had to update esLint to handle the optional chaining
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 43 44 +1
Lines 879 918 +39
Branches 220 230 +10
==========================================
+ Hits 859 897 +38
- Misses 17 18 +1
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yeonjuan
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
LGTM. Thank you very much for your contribution! @Adam-Gillespie345
This change will be included in the next release. I'll do some testing and release a new version in the next week!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the code I discussed in the issue earlier, I could have extended the no-restricted-attr rule to also encompass values but felt this might dilute the purpose of the rule so created a new one. This rule will allow users to disable the use certain values on certain attributes which will help in the prevention of security leaks to third party services.