Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support linting html in template literals in no-extra-spacing-text #239

Merged
merged 6 commits into from
Dec 1, 2024

Conversation

yeonjuan
Copy link
Owner

@yeonjuan yeonjuan commented Dec 1, 2024

Applying template-parser to the rules

  • no-extra-spacing-text
  • no-multiple-empty-lines
  • no-trailing-spaces

@yeonjuan yeonjuan marked this pull request as ready for review December 1, 2024 14:58
@yeonjuan yeonjuan merged commit 80a2bec into main Dec 1, 2024
5 checks passed
@yeonjuan yeonjuan deleted the 225/no-extra-spacing branch December 1, 2024 14:58
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 94.65649% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.94%. Comparing base (ed2a3b3) to head (4df4e4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eslint-plugin/lib/rules/no-multiple-empty-lines.js 91.42% 3 Missing ⚠️
...ages/eslint-plugin/lib/rules/no-trailing-spaces.js 92.10% 3 Missing ⚠️
...s/eslint-plugin/lib/rules/no-extra-spacing-text.js 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   98.32%   97.94%   -0.39%     
==========================================
  Files          57       57              
  Lines        1494     1556      +62     
  Branches      407      418      +11     
==========================================
+ Hits         1469     1524      +55     
- Misses         25       32       +7     
Flag Coverage Δ
unittest 97.94% <94.65%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/eslint-plugin/lib/rules/element-newline.js 100.00% <100.00%> (ø)
...ackages/eslint-plugin/lib/rules/no-duplicate-id.js 97.36% <100.00%> (ø)
packages/eslint-plugin/lib/rules/no-multiple-h1.js 100.00% <100.00%> (ø)
.../eslint-plugin/lib/rules/no-skip-heading-levels.js 100.00% <100.00%> (ø)
...es/eslint-plugin/lib/rules/require-li-container.js 100.00% <100.00%> (ø)
packages/eslint-plugin/lib/rules/utils/node.js 92.42% <100.00%> (+1.19%) ⬆️
packages/template-parser/lib/template-parser.js 100.00% <100.00%> (ø)
...s/eslint-plugin/lib/rules/no-extra-spacing-text.js 98.07% <96.87%> (-1.93%) ⬇️
...eslint-plugin/lib/rules/no-multiple-empty-lines.js 92.50% <91.42%> (-7.50%) ⬇️
...ages/eslint-plugin/lib/rules/no-trailing-spaces.js 92.85% <92.10%> (-7.15%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant