PR feedbacks w.r.t error handling

yesil · Sep 3, 2024 · e7539d1 · e7539d1
1 parent 68ffdd7
commit e7539d1
Show file tree

Hide file tree

Showing 5 changed files with 156 additions and 79 deletions.
diff --git a/libs/deps/mas/mas.js b/libs/deps/mas/mas.js
diff --git a/libs/deps/mas/merch-datasource.js b/libs/deps/mas/merch-datasource.js
diff --git a/libs/features/mas/mocks/aem.js b/libs/features/mas/mocks/aem.js
@@ -14,6 +14,8 @@ export async function withAem(originalFetch) {
                 .then(({ items }) => items.find((item) => item.path === path));
             if (item) {
                 return Promise.resolve({
+                    ok: true,
+                    status: 200,
                     json: () => Promise.resolve({ items: [item] }),
                 });
             }

diff --git a/libs/features/mas/mocks/sites/cf/fragments/search/default.json b/libs/features/mas/mocks/sites/cf/fragments/search/default.json
@@ -295,7 +295,7 @@
                     "locked": false,
                     "mimeType": "text/html",
                     "values": [
-                        "<p>Join us for the creative event of the year Oct 14–16. Register by August 31 and save US$200 on a full conference pass.</p><p><a class=\"modal link-block \" href=\"https://www.adobe.com/products/special-offers.html#max-modal-advanced\" data-modal-path=\"/cc-shared/fragments/modals/max-conference/terms-advanced-pricing\" data-modal-hash=\"#max-modal-advanced\">See terms</a></p>"
+                        "<p>Join us for the creative event of the year Oct 14-16. Register by August 31 and save US$200 on a full conference pass.</p><p><a class=\"modal link-block \" href=\"https://www.adobe.com/products/special-offers.html#max-modal-advanced\" data-modal-path=\"/cc-shared/fragments/modals/max-conference/terms-advanced-pricing\" data-modal-hash=\"#max-modal-advanced\">See terms</a></p>"
                     ]
                 },
                 {