[SQL-157] Encoding fix #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/modify util functions that encode or decode strings such that the charset is always fixed to UTF-8, and replace all instances of
Stringconstructor calls to use said util functions. Also add tests on Unicode characters.TODO: However, these fixes are not enough to address the issues causing the SQL-157 Out of Memory Error bug caused by incorrect encoding. This will have to wait until thelrslibrary can be updated.Turns out updating the
lrslib is impractical due to the default charset being used deep within Pedestal (see here). Thus we instead set the default encoding using Java variables in our shell scripts and executable configs.