Miscellaneous updates #262
Conversation
| @@ -11,4 +11,4 @@ | |||
| :pool-leak-detection-threshold 0 | |||
| :pool-transaction-isolation nil | |||
| :pool-name nil | |||
| :pool-enable-jmx false} | |||
| :pool-enable-jmx true} | |||
There was a problem hiding this comment.
Isn't this just JMX for the conn pool? the description made it seem like it was across the board. Also if the benchmarks use the test profile I'm pretty sure you'll want all JMX off
There was a problem hiding this comment.
Yes I should've specified that in the description. In fact I was motivated to turn this on since JMX was turned on for other classes, such as Pedestal.
I didn't realize it might affect benching though; if that's true it would be a good reason to revert the change (and add a comment in the config file). I do wonder why it's JMX on the conn pool, and not on other classes, that'll affect this.
There was a problem hiding this comment.
Also if the benchmarks use the test profile I'm pretty sure you'll want all JMX off
Oh didn't see that. Given that all benching has been done with the "some JMX is on" configuration I've talked about, I'm not sure if adding some to the conn pool will affect things that much.
| (dorun (map (partial bp/-insert-credential-scope! bk tx) input))) | ||
| (run! (partial bp/-insert-credential-scope! bk tx) input)) |
Some things I wanted to fix before the upcoming break ver is released
(dorun (map ...))withrun!