Reactions #306
Merged
Reactions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SQL-197 input->ruleset * SQL-197 add reaction table * SQL-197 SQL-198 add persistence for reactions and fk on xapi_statement * SQL-197 a migration that actually works * use fake timestamp types by convention and add active/inactive/soft delete bool * ReactionQueryBackend -> ReactionBackend * SQL-197 CRUD queries/commands * SQL-197 stubbed out reaction values for statement insert * SQL-197 function for storing reaction exts info on statement * SQL-197 standardize spec ns a bit * SQL-197 more spec refactor * SQL-197 remove comment * SQL-197 add reaction and trigger id as metadata * SQL-197 inputs for reaction crud sql fns * SQL-197 test for add meta * SQL-197 specs for persistence ops * SQL-197 get rid of keywords in values and path segments * SQL-197 serde for reaction ruleset * SQL-197 ruleset commands * SQL-197 return active rulesets query * SQL-197 reaction CRUD protocol and test * SQL-197 remove forward declaration in spec * SQL-197 delint * SQL-197 use :as-alias and remove kondo exception
…tement and a statement template, returning a new statement based on template
* SQL-198 move low-level queries to util and stub out reaction fn * SQL-198 dedupe test reaction * SQL-198 use new test const in reaction util test * SQL-198 add template to ruleset * SQL-198 add instrumentation fixture, now some spec-violating tests fail * SQL-198 instrument and ensure valid specs in reaction util tests * SQL-198 instrument and fix specs for ops/util/reaction * SQL-198 type new id fields on statement * SQL-198 query-active-reactions test * SQL-198 query-all-reactions test * SQL-198 correct aliasing in reaction util query test ns * SQL-198 query-statement-for-reaction * SQL-198 query-reaction-history * SQL-198 remove query-statement-for-reaction * SQL-198 refactor some more test consts * SQL-198 formatting * SQL-198 actual reaction function * SQL-198 SQL-200 pass errors
* SQL-200 json-friendly error shape and slight refactor * SQL-200 add error column * SQL-200 add delete mod time * SQL-200 error-reaction! command * SQL-200 clear error on ruleset update * SQL-200 react-to-statement * SQL-200 SQL-198 SQL-193 Add authority to query output based on ruleset or trigger * SQL-200 delint * SQL-200 correct testing statement * SQL-200 react-to-statement error storage test * SQL-200 delint * SQL-200 derive custom authority from template
* SQL-195 config toggle for enabling reactions * SQL-195 moved react-to-statement to new reactor system component * SQL-195 reaction buffer size param * SQL-195 correct default for buffer size * SQL-195 submit new statements to reaction channel * SQL-195 working async reaction processing * SQL-195 add shutdown hook for graceful shutdown * SQL-195 added note about what happens when reaction buffer is full
* partial refactor of big reaction query op * further break down reaction q * further refactor and commenting
kelvinqian00
approved these changes
Jan 23, 2024
cliffcaseyyet
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL-211 Statement Reactions
Ye Docs
PR on
lrs-admin-uihere: yetanalytics/lrs-admin-ui#49PR onre-codemirrorhere: yetanalytics/re-codemirror#3Shared lib here: https://github.com/yetanalytics/lrs-reactions