Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL-250] UI no longer cares about HTML #414

Merged
merged 4 commits into from
Jun 18, 2024
Merged

[SQL-250] UI no longer cares about HTML #414

merged 4 commits into from
Jun 18, 2024

Conversation

cliffcaseyyet
Copy link
Member

TODO: bump UI version after release.

@kelvinqian00
Copy link
Collaborator

SQLite CI is failing...

@kelvinqian00
Copy link
Collaborator

kelvinqian00 commented Jun 18, 2024

In addition, we'll need to update the env var docs to say that LRSQL_ENABLE_STMT_HTML will no longer affect the statement browser in UI. Right now this is the description (emphasis mine):

Whether or not HTML data is returned in the LRS HTTP response. If false disables HTML rendering even if LRSQL_ENABLE_ADMIN_UI is true. In that case the UI will not display the Statement Browser feature.

Copy link
Collaborator

@kelvinqian00 kelvinqian00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear I missed a spot:

- `GET http://example.org/admin/env`: Get select environment variables about the configuration which may aid in client-side operations. Currently returns a map containing the configuration variables `urlPrefix` and `enableStmtHtml`.

@cliffcaseyyet
Copy link
Member Author

Oh dear I missed a spot:

- `GET http://example.org/admin/env`: Get select environment variables about the configuration which may aid in client-side operations. Currently returns a map containing the configuration variables `urlPrefix` and `enableStmtHtml`.

2f4198c

@cliffcaseyyet cliffcaseyyet merged commit ef85f52 into main Jun 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants