Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LRS-83] POST with empty list #421

Merged
merged 10 commits into from
Oct 7, 2024
Merged

[LRS-83] POST with empty list #421

merged 10 commits into from
Oct 7, 2024

Conversation

deathtenk
Copy link
Contributor

This adds a test for POST with empty list

@kelvinqian00 kelvinqian00 changed the title POST with empty list [LRS-83] POST with empty list Aug 27, 2024
@cliffcaseyyet
Copy link
Member

@deathtenk can you close this one since we went the schema route in the end?

@kelvinqian00
Copy link
Collaborator

@cliffcaseyyet (Sorry just saw that you responded) Actually I would not close this PR, since I added commits to this branch to bring in the updated schema deps + new tests.

@cliffcaseyyet
Copy link
Member

@cliffcaseyyet (Sorry just saw that you responded) Actually I would not close this PR, since I added commits to this branch to bring in the updated schema deps + new tests.

Ah ok, i thought this was the alternative path from what you did.

@kelvinqian00 kelvinqian00 marked this pull request as ready for review October 7, 2024 14:58
@kelvinqian00 kelvinqian00 requested a review from milt October 7, 2024 14:58
@kelvinqian00 kelvinqian00 merged commit 8f76505 into main Oct 7, 2024
15 of 16 checks passed
@kelvinqian00 kelvinqian00 deleted the post-empty-list branch October 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants