Manage device rooms with flux pattern using the reflux implementation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsblumberg
force-pushed
the
feature/list-all-rooms
branch
from
b5d18a6 to
5c97814
Compare
|
|
||
| var roomStore = require('stores/room'); | ||
| var roomActions = require('../../../actions/room'); |
There was a problem hiding this comment.
Here we can use alias instead of referring module in this way.
larsblumberg
added a commit
that referenced
this pull request
Mar 2, 2015
Manage device rooms with flux pattern using the reflux implementation
|
I will double Artem's question: why do we need to specify Otherwise, LGTM |
|
@larsblumberg So, it's a good idea to add those keys all the time, right? |
This quote is from here: facebook/react#1342 (comment) So, there is no need to use index explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.