Feature/use grid layout #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The “main” isn’t necessary
Navigation bar goes from left to top on small screens
| <Route path="/" handler={MainScreen}> | ||
| <Route name="settings" handler={SettingsRegion}/> | ||
| <Route name="devices" handler={DevicesRegion}/> | ||
| <Redirect from="/" to="devices"/> | ||
| </Route> |
There was a problem hiding this comment.
You decided to get rid of subrouting for now?
There was a problem hiding this comment.
Yes, there's currently no need for it. Can be added if necessary
There was a problem hiding this comment.
Yep, anyway we do know how it works.
|
LGTM, there are however some comments |
|
Me as well |
| var Device = require('screens/main/devices/device/index'); | ||
| var Device = require('../device'); | ||
|
|
||
| require('./style.scss'); |
There was a problem hiding this comment.
Why StyleMixin isn't used here?
There was a problem hiding this comment.
was not part of the PR, we worked on the main screen and navigation bar. This could be done by a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dev-tim You should be unblocked after the merge