Fix CI builds

Cargo.toml

@@ -95,6 +95,10 @@ features = [
   "WorkerOptions",
 ]
 
+# Changes here must be reflected in `build.rs`
+[target.'cfg(all(target_arch = "wasm32", not(target_os="wasi"), not(cargo_web)))'.dependencies]
+wasm-bindgen = "0.2.58"
+
 # Changes here must be reflected in `build.rs`
 [target.'cfg(all(target_arch = "wasm32", not(target_os="wasi"), not(cargo_web)))'.dev-dependencies]
 wasm-bindgen-test = "0.3.4"
@@ -104,15 +108,12 @@ ryu = "1.0.2" # 1.0.1 breaks emscripten
 
 [dev-dependencies]
 serde_derive = "1"
-trybuild = "1.0"
-rustversion = "1.0"
 
 [features]
-default = ["services", "agent"]
+default = []
 std_web = ["stdweb"]
 web_sys = ["console_error_panic_hook", "gloo", "js-sys", "web-sys", "wasm-bindgen"]
 doc_test = []
-web_test = []
 wasm_test = []
 services = []
 agent = ["bincode"]

build.rs

@@ -18,9 +18,7 @@ pub fn main() {
 
     let target_arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap_or_default();
     let using_wasm_bindgen = target_arch == "wasm32" && !using_cargo_web && !using_wasi;
-    if using_wasm_bindgen {
-        println!("cargo:rustc-cfg=feature=\"wasm_bindgen_test\"");
-    } else if cfg!(all(feature = "web_sys", not(feature = "doc_test"))) {
+    if !using_wasm_bindgen && cfg!(all(feature = "web_sys", not(feature = "doc_test"))) {
         let target = env::var("TARGET").unwrap_or_default();
         panic!(
             "Selected target `{}` is not compatible with web-sys",

ci/run_checks.sh

@@ -8,4 +8,5 @@ fi
 
 set -euxo pipefail
 cargo fmt --all -- --check
-cargo clippy -- --deny=warnings
+cargo clippy --features std_web -- --deny=warnings
+cargo clippy --target wasm32-unknown-unknown --features web_sys -- --deny=warnings

ci/run_tests.sh

@@ -5,12 +5,16 @@ set -euxo pipefail # https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_
 
 if [ "$emscripten_supported" == "0" ]; then
   # TODO - Emscripten builds are broken on rustc > 1.39.0
-  cargo web test --features web_test --target asmjs-unknown-emscripten
-  cargo web test --features web_test --target wasm32-unknown-emscripten
+  cargo web test --target asmjs-unknown-emscripten --features std_web
+  cargo web test --target wasm32-unknown-emscripten --features std_web
 fi
 
-cargo test --features wasm_test --target wasm32-unknown-unknown
-cargo test --test macro_test
-cargo test --test derive_props_test
-cargo test --doc --all-features
-(cd crates/macro && cargo test --doc)
+cargo test --target wasm32-unknown-unknown --features wasm_test,std_web
+cargo test --target wasm32-unknown-unknown --features wasm_test,web_sys
+cargo test --doc --features doc_test,wasm_test,yaml,msgpack,cbor,std_web
+cargo test --doc --features doc_test,wasm_test,yaml,msgpack,cbor,web_sys
+
+(cd crates/macro \
+  && cargo test --test macro_test \
+  && cargo test --test derive_props_test \
+  && cargo test --doc)

crates/macro/Cargo.toml

@@ -25,8 +25,11 @@ proc-macro2 = "1.0"
 quote = "1.0"
 syn = { version = "1.0", features = ["full", "extra-traits"] }
 
+# testing
 [dev-dependencies]
-yew = { path = "../.." }
+rustversion = "1.0"
+trybuild = "1.0"
+yew = { path = "../..", features = ["std_web"] }
 
 [build-dependencies]
 autocfg = "1.0.0"

tests/derive_props_test.rs → crates/macro/tests/derive_props_test.rs

@@ -1,5 +1,5 @@
 #[allow(dead_code)]
-#[rustversion::attr(stable(1.40.0), cfg_attr(not(feature = "web_test"), test))]
+#[rustversion::attr(stable(1.40.0), test)]
 fn tests() {
     let t = trybuild::TestCases::new();
     t.pass("tests/derive_props/pass.rs");

tests/macro/html-component-fail.stderr → crates/macro/tests/macro/html-component-fail.stderr

@@ -188,6 +188,10 @@ error[E0599]: no method named `string` found for type `ChildPropertiesBuilder<Ch
 ...
 72 |     html! { <Child string="abc" /> };
    |                    ^^^^^^ method not found in `ChildPropertiesBuilder<ChildPropertiesBuilderStep_missing_required_prop_int>`
+   |
+   = help: items from traits can only be used if the trait is implemented and in scope
+   = note: the following trait defines an item `string`, perhaps you need to implement it:
+           candidate #1: `proc_macro::bridge::server::Literal`
 
 error[E0599]: no method named `children` found for type `ChildPropertiesBuilder<ChildPropertiesBuilderStep_missing_required_prop_int>` in the current scope
   --> $DIR/html-component-fail.rs:76:5
@@ -209,6 +213,9 @@ error[E0599]: no method named `build` found for type `ChildContainerPropertiesBu
 78 |     html! { <ChildContainer /> };
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `ChildContainerPropertiesBuilder<ChildContainerPropertiesBuilderStep_missing_required_prop_children>`
    |
+   = help: items from traits can only be used if the trait is implemented and in scope
+   = note: the following trait defines an item `build`, perhaps you need to implement it:
+           candidate #1: `proc_macro::bridge::server::TokenStreamBuilder`
    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 
 error[E0599]: no method named `build` found for type `ChildContainerPropertiesBuilder<ChildContainerPropertiesBuilderStep_missing_required_prop_children>` in the current scope
@@ -220,6 +227,9 @@ error[E0599]: no method named `build` found for type `ChildContainerPropertiesBu
 79 |     html! { <ChildContainer></ChildContainer> };
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `ChildContainerPropertiesBuilder<ChildContainerPropertiesBuilderStep_missing_required_prop_children>`
    |
+   = help: items from traits can only be used if the trait is implemented and in scope
+   = note: the following trait defines an item `build`, perhaps you need to implement it:
+           candidate #1: `proc_macro::bridge::server::TokenStreamBuilder`
    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 
 error[E0277]: the trait bound `yew::virtual_dom::vcomp::VChild<Child>: std::convert::From<&str>` is not satisfied

tests/macro_test.rs → crates/macro/tests/macro_test.rs

@@ -1,5 +1,5 @@
 #[allow(dead_code)]
-#[rustversion::attr(stable(1.40.0), cfg_attr(not(feature = "web_test"), test))]
+#[rustversion::attr(stable(1.40.0), test)]
 fn tests() {
     let t = trybuild::TestCases::new();
 

examples/counter/Cargo.toml

@@ -6,4 +6,4 @@ edition = "2018"
 
 [dependencies]
 stdweb = "0.4.20"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/crm/Cargo.toml

@@ -7,5 +7,5 @@ edition = "2018"
 [dependencies]
 serde = "1"
 serde_derive = "1"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }
 pulldown-cmark = "0.1.2"

examples/custom_components/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Denis Kolodin <deniskolodin@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/dashboard/Cargo.toml

@@ -8,4 +8,4 @@ edition = "2018"
 anyhow = "1"
 serde = "1"
 serde_derive = "1"
-yew = { path = "../..", features = ["toml"] }
+yew = { path = "../..", features = ["std_web", "services", "toml"] }

examples/file_upload/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Denis Kolodin <deniskolodin@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/fragments/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Denis Kolodin <deniskolodin@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/futures/Cargo.toml

@@ -11,7 +11,7 @@ repository = "https://github.com/yewstack/yew"
 crate-type = ["cdylib", "rlib"]
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }
 wasm-bindgen-futures = "0.4.3"
 
 [dependencies.web-sys]

examples/game_of_life/Cargo.toml

@@ -10,4 +10,4 @@ edition = "2018"
 rand = { version = "0.6.5", features = ["stdweb"] }
 log = "0.4"
 web_logger = "0.1"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/inner_html/Cargo.toml

@@ -6,4 +6,4 @@ edition = "2018"
 
 [dependencies]
 stdweb = "0.4.20"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/js_callback/Cargo.toml

@@ -5,7 +5,7 @@ authors = ["Scott Steele <scottlsteele@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }
 stdweb = "^0.4.20"
 
 [target.'cfg(all(target_arch = "wasm32", not(cargo_web)))'.dependencies]

examples/large_table/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["qthree <qthree3@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/minimal/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Denis Kolodin <deniskolodin@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/mount_point/Cargo.toml

@@ -6,4 +6,4 @@ edition = "2018"
 
 [dependencies]
 stdweb = "0.4.20"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/multi_thread/Cargo.toml

@@ -17,4 +17,4 @@ log = "0.4"
 web_logger = "0.1"
 serde = "1.0"
 serde_derive = "1.0"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/nested_list/Cargo.toml

@@ -7,4 +7,4 @@ edition = "2018"
 [dependencies]
 log = "0.4"
 web_logger = "0.2"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/node_refs/Cargo.toml

@@ -5,5 +5,5 @@ authors = ["Justin Starry <justin.starry@icloud.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }
 stdweb = "0.4.20"

examples/npm_and_rest/Cargo.toml

@@ -9,4 +9,4 @@ anyhow = "1"
 serde = "1"
 serde_derive = "1"
 stdweb = "0.4.20"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/showcase/Cargo.toml

@@ -10,6 +10,8 @@ web_logger = "0.1"
 strum = "0.13"
 strum_macros = "0.13"
 yew = { path = "../.." }
+
+# examples
 counter = { path = "../counter" }
 crm = { path = "../crm" }
 custom_components = { path = "../custom_components" }

examples/textarea/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Andrew Straw <strawman@astraw.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

examples/timer/Cargo.toml

@@ -5,4 +5,4 @@ authors = ["Denis Kolodin <deniskolodin@gmail.com>"]
 edition = "2018"
 
 [dependencies]
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/todomvc/Cargo.toml

@@ -9,4 +9,4 @@ strum = "0.13"
 strum_macros = "0.13"
 serde = "1"
 serde_derive = "1"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web", "services"] }

examples/two_apps/Cargo.toml

@@ -6,4 +6,4 @@ edition = "2018"
 
 [dependencies]
 stdweb = "0.4.20"
-yew = { path = "../.." }
+yew = { path = "../..", features = ["std_web"] }

src/format/macros.rs

@@ -53,6 +53,7 @@ macro_rules! binary_format {
     };
 }
 
+#[cfg(any(feature = "bincode", feature = "cbor", feature = "msgpack"))]
 macro_rules! text_format_is_an_error {
     ($type:ident) => {
         use $crate::format::FormatError;

tests/vtag_test.rs

@@ -1,4 +1,6 @@
 #![recursion_limit = "128"]
+
+#[cfg(feature = "std_web")]
 use stdweb::web::{document, IElement};
 #[cfg(feature = "wasm_test")]
 use wasm_bindgen_test::{wasm_bindgen_test as test, wasm_bindgen_test_configure};
@@ -270,8 +272,16 @@ fn assert_namespace(vtag: &VTag, namespace: &'static str) {
 
 #[test]
 fn supports_svg() {
-    let div_el = document().create_element("div").unwrap();
-    let svg_el = document().create_element_ns(SVG_NAMESPACE, "svg").unwrap();
+    #[cfg(feature = "std_web")]
+    let document = document();
+    #[cfg(feature = "web_sys")]
+    let document = web_sys::window().unwrap().document().unwrap();
+
+    let div_el = document.create_element("div").unwrap();
+    let namespace = SVG_NAMESPACE;
+    #[cfg(feature = "web_sys")]
+    let namespace = Some(namespace);
+    let svg_el = document.create_element_ns(namespace, "svg").unwrap();
 
     let mut g_node = html! { <g></g> };
     let path_node = html! { <path></path> };