Move CI to GitHub Actions #1474
Conversation
The intent was for this to run tests on
Fine with this
Not too concerned about Mergify. It's a nice to have but this PR makes things so much better that there's less need for mergify :) |
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Oh right, I totally didn't notice the |
|
Alright, that should be everything! Only took me like 3 hours 😭 ... |
|
Lol, that's CI for ya. Really appreciate it! |
* clippy in tests * add pull request workflow * fix formatting * add names to steps * fix clippy * update * avoid mutable * use wasm target * install it too * except there * let's give chrome a spin * clippy has some more to say * only run specific tests * fix tests on chrome * add cache * rename benchmark for consistency * re-enable geckodriver * clean up old files * remove all mentions of Travis * check all examples * let's try with a bigger timeout * test both browsers at the same time * chrome really doesn't like me * finish up * run for pushes to master * improve caching * fix order in workspace members * clippy use --all-targets * rename workflow file * Apply suggestions from code review Co-authored-by: Justin Starry <justin.m.starry@gmail.com> * use stable toolchain for lints * run lints on nightly too * add doctest for yew-stdweb * allow failure for nightly clippy steps * let's try it on the job level again * always run all lint steps * only run lints on stable toolchain * use 'no_run' instead of 'ignore' Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
* clippy in tests * add pull request workflow * fix formatting * add names to steps * fix clippy * update * avoid mutable * use wasm target * install it too * except there * let's give chrome a spin * clippy has some more to say * only run specific tests * fix tests on chrome * add cache * rename benchmark for consistency * re-enable geckodriver * clean up old files * remove all mentions of Travis * check all examples * let's try with a bigger timeout * test both browsers at the same time * chrome really doesn't like me * finish up * run for pushes to master * improve caching * fix order in workspace members * clippy use --all-targets * rename workflow file * Apply suggestions from code review Co-authored-by: Justin Starry <justin.m.starry@gmail.com> * use stable toolchain for lints * run lints on nightly too * add doctest for yew-stdweb * allow failure for nightly clippy steps * let's try it on the job level again * always run all lint steps * only run lints on stable toolchain * use 'no_run' instead of 'ignore' Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
The pull request checks are the only thing that's still using Travis. This PR moves them to GitHub Actions and expands the checks a bit.
Notable Changes
cargo check)Benefits:
I left
run_stable_checks.shandrun_tests.shfor now because they're useful to contributors.The changes uncovered some new Clippy issues which explains the remaining changes in this PR.
Potential issues
1
I didn't port `cargo test --doc --features doc_test,wasm_test,yaml,msgpack,cbor,toml --features std_web,agent,services --no-default-features`. I don't think this adds anything to the existing tests since it just activates all default features manually.2
The following part of
run_stable_checks.shis missing:It's the only part that requires cargo-web. Since it's just a single example in
yew-stdweb, I don't think it's really necessary.3
Not sure whether Mergify can deal with this because it's no longer just a single check and Mergify's documentation mentions something about this: https://doc.mergify.io/conditions.html#validating-all-status-check.