-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move yew/format and yew/agent to their own crates #1726
Conversation
Welp, looks like I based this off a wrong branch. If there's any way to fix this, please let me know, otherwise I'll have to recreate this. |
Visit the preview URL for this PR (updated for commit 7582236): https://yew-rs--pr1726-agent-format-crate-ci6wgitq.web.app (expires Wed, 28 Apr 2021 18:15:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
You can rebase? |
e973453
to
bd49f0b
Compare
Yes, a rebase fixed everything |
bd49f0b
to
8724c86
Compare
8724c86
to
6cf55de
Compare
This also gets rid of unused dependencies
Unit tests on nightly fail because of Alexhuszagh/rust-lexical#55 so I commented out the line for those in workflow temporarily |
The macro unit tests are failing, not sure what's up with those. Also, in case anyone wants to take a look, this PR should be ready. |
The macro tests should be fixed on master |
# Conflicts: # packages/yew-format/src/macros.rs
Closing in favor of #1842 |
Description
This is 2nd part of my PR #1693. That PR moved
yew/services
module toyew-services
. This one movesyew/format
andyew/agent
toyew-format
andyew-agent
respectively. This is another part of the work needed to be done for #1670.I have also taken the liberty of removing some unused dependencies that were in
yew
To do list
yew/format
toyew-format
yew/agent
toyew-agent
Checklist
cargo make pr-flow