Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yew/format and yew/agent to their own crates #1726

Closed
wants to merge 5 commits into from

Conversation

ranile
Copy link
Member

@ranile ranile commented Feb 3, 2021

Description

This is 2nd part of my PR #1693. That PR moved yew/services module to yew-services. This one moves yew/format and yew/agent to yew-format and yew-agent respectively. This is another part of the work needed to be done for #1670.

I have also taken the liberty of removing some unused dependencies that were in yew

To do list

  • Move yew/format to yew-format
  • Move yew/agent to yew-agent

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@ranile
Copy link
Member Author

ranile commented Feb 3, 2021

Welp, looks like I based this off a wrong branch. If there's any way to fix this, please let me know, otherwise I'll have to recreate this.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Visit the preview URL for this PR (updated for commit 7582236):

https://yew-rs--pr1726-agent-format-crate-ci6wgitq.web.app

(expires Wed, 28 Apr 2021 18:15:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@teymour-aldridge
Copy link
Contributor

You can rebase?

@ranile ranile force-pushed the agent-format-crate branch from e973453 to bd49f0b Compare February 3, 2021 11:25
@ranile
Copy link
Member Author

ranile commented Feb 3, 2021

Yes, a rebase fixed everything

@ranile ranile force-pushed the agent-format-crate branch from bd49f0b to 8724c86 Compare February 3, 2021 11:27
@ranile ranile force-pushed the agent-format-crate branch from 8724c86 to 6cf55de Compare February 3, 2021 11:59
This also gets rid of unused dependencies
@ranile
Copy link
Member Author

ranile commented Feb 3, 2021

Unit tests on nightly fail because of Alexhuszagh/rust-lexical#55 so I commented out the line for those in workflow temporarily

@ranile ranile marked this pull request as ready for review February 3, 2021 13:08
@ranile
Copy link
Member Author

ranile commented Feb 25, 2021

The macro unit tests are failing, not sure what's up with those.

Also, in case anyone wants to take a look, this PR should be ready.

@lukechu10
Copy link
Contributor

The macro unit tests are failing, not sure what's up with those.

Also, in case anyone wants to take a look, this PR should be ready.

The macro tests should be fixed on master

# Conflicts:
#	packages/yew-format/src/macros.rs
@ranile
Copy link
Member Author

ranile commented May 7, 2021

Closing in favor of #1842

@ranile ranile closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants