Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Some Router Behaviour #2107

Merged
merged 7 commits into from
Oct 16, 2021
Merged

Fix Some Router Behaviour #2107

merged 7 commits into from
Oct 16, 2021

Conversation

futursolo
Copy link
Member

@futursolo futursolo commented Oct 9, 2021

Description

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@mc1098 mc1098 added A-yew-router Area: The yew-router crate A-yew-router-macro Area: The yew-router-macro crate labels Oct 10, 2021
@mc1098
Copy link
Contributor

mc1098 commented Oct 13, 2021

Thanks for the PR ❤️

There is still some discussion in #2106 so I'm going to see what comes of that first before reviewing in-depth, in part because I don't want to request changes only to change after you've done more work :)

I will say that this PR should only have one concern and that is fixing #2106 so I would omit the + Add <Redirect /> part and create a new issue for adding the Redirect component - they are two different units of changes and one could potentially stop the other from being merged in!

@futursolo futursolo changed the title Fix Some Router Behaviour + Add <Redirect /> Fix Some Router Behaviour Oct 14, 2021
@futursolo
Copy link
Member Author

futursolo commented Oct 14, 2021

@mc1098 I have removed <Redirect /> and created #2113.

Also I am not sure why cargo make pr-flow requires 77b46bf to be reverted before it can pass so I have reverted it.
If CI does not like it I will readd it to let CI pass.

@mc1098
Copy link
Contributor

mc1098 commented Oct 15, 2021

Also I am not sure why cargo make pr-flow requires 77b46bf to be reverted before it can pass so I have reverted it.
If CI does not like it I will readd it to let CI pass.

cargo update

This will update the dependencies in the lock file :) Run this and then you should see cargo make pr-flow failing locally too.

@mc1098
Copy link
Contributor

mc1098 commented Oct 16, 2021

Sorry for taking awhile to merge this :)

I always try and allow some time when there is some objection in either the issue or PR, that and I've been busy too 🙃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-router Area: The yew-router crate A-yew-router-macro Area: The yew-router-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router does not match #[not_found] if it fails to parse into the target type
2 participants