-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks completely redone #2352
Conversation
I would assume that there is no comment on my commit atm, because master latest commit has not been benchmarked and thus my commit has nothing to be compared against. |
Where does it store the previous results needed to build the new site? |
In |
I wonder whether the accumulated graph makes sense in the long term, since we can't control the hardware in github actions. |
Copied from https://github.com/krausest/js-framework-benchmark | ||
|
||
It should ideally stay/be updated to always match what is on https://github.com/krausest/js-framework-benchmark | ||
Except the fixes required to tun using unreleased yew version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the fixes required to tun using unreleased yew version. | |
Except the fixes required to run using unreleased yew version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nothing against this. If any issues pop up, those can be resolved later.
I do share the runner hardware concerns mentioned in #2352.
A (potentially crazy) idea I had was to save the benchmark results in Firestore. Not sure how applicable that is though
Description
A lot has been done so here is a compiled list to get you up to speed:
js-framework-benchmark
, beingtools/benchmark-struct
tools/benchmark-hooks
gh-pages
branch and we can serve that using github pagestools/process-benchmark-results
introduced, to transform data to be ready for github-action-benchmarkPreview:
gh-pages page
Comment on the commit with the results:
![image](https://user-images.githubusercontent.com/32368314/148696140-8cfd0ae2-d1d0-4b90-8282-e5fcb2d06c86.png)
Alert comment when
![image](https://user-images.githubusercontent.com/32368314/148696280-1313f92f-95d9-414c-a893-eda2103a307a.png)
150%
threshold is reached:Fixes #1453
Fixes #858
Touches #5 I would just need to add docs about these benchmarks somehow
Checklist
cargo make pr-flow