Add support for class="class1 class2" #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anga
changed the title
anga
changed the title
therustmonk
force-pushed
the
add_classess_support
branch
from
b852218 to
41be324
Compare
|
@anga I've improved this PR if you don't mind:
|
READY FOR MERGE
|
@deniskolodin of course not. Thanks for review this. I agree 100% with your changes, I forgot about |
|
Great! Thank you for this PR! I'm starting to merge it 🎉 |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 19, 2018
289: Add support for class="class1 class2" r=DenisKolodin a=anga This is not a final code, but works. It use regex create to split with space (`\s+`). Should we split by any other character? with this, you can now do `class="class1 class2 class3"` without problem. Maybe I can update `attach_class` and not create a similar new one, don't know what you think. **EDIT:** Maybe use `lazy_static!` to build the regexp object to prevent build it every time? Co-authored-by: anga <andres.b.dev@gmail.com>
Build succeeded |
This was referenced Jun 19, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a final code, but works. It use regex create to split with space (
\s+). Should we split by any other character?with this, you can now do
class="class1 class2 class3"without problem.Maybe I can update
attach_classand not create a similar new one, don't know what you think.EDIT: Maybe use
lazy_static!to build the regexp object to prevent build it every time?