Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces the FromQuery and IntoQuery traits #3565

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Roba1993
Copy link

Description

Introduces the FromQuery and IntoQuery traits following the gloo_history approach.

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Dec 21, 2023

Visit the preview URL for this PR (updated for commit 7bf8573):

https://yew-rs-api--pr3565-master-oexio1cr.web.app

(expires Thu, 23 Jan 2025 14:46:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Dec 21, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.453 311.071 310.712 0.201
Hello World 10 484.446 495.996 492.455 4.261
Function Router 10 1597.638 1614.584 1605.808 5.510
Concurrent Task 10 1005.359 1007.086 1006.530 0.533
Many Providers 10 1075.903 1120.732 1090.026 15.994

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.371 314.290 310.899 1.196
Hello World 10 485.406 498.578 492.060 3.483
Function Router 10 1580.487 1610.186 1594.773 8.791
Concurrent Task 10 1005.289 1007.502 1006.620 0.700
Many Providers 10 1072.566 1148.209 1098.927 24.089

Copy link

github-actions bot commented Dec 21, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)

✅ None of the examples has changed their size significantly.

@Roba1993
Copy link
Author

@ranile Can this be added to the 0.22 release? I just have some clips problems which are not from me? Which are blocking the merge....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant