Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces the FromQuery and IntoQuery traits #3565

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Roba1993
Copy link

Description

Introduces the FromQuery and IntoQuery traits following the gloo_history approach.

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Dec 21, 2023

Visit the preview URL for this PR (updated for commit 304a6a5):

https://yew-rs-api--pr3565-master-slh8pevl.web.app

(expires Thu, 28 Dec 2023 17:17:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Dec 21, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.893 309.425 309.079 0.204
Hello World 10 489.960 513.900 494.879 7.065
Function Router 10 1644.388 1665.911 1654.688 6.000
Concurrent Task 10 1006.062 1007.361 1006.706 0.353
Many Providers 10 1129.937 1161.670 1146.195 9.802

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.936 314.256 309.711 1.624
Hello World 10 511.481 522.605 516.148 3.963
Function Router 10 1610.340 1629.883 1617.937 6.474
Concurrent Task 10 1005.831 1006.844 1006.378 0.336
Many Providers 10 1115.027 1152.301 1131.129 11.145

Copy link

github-actions bot commented Dec 21, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 101.086 101.086 0 0.000%
boids 174.742 174.742 0 0.000%
communication_child_to_parent 93.484 93.484 0 0.000%
communication_grandchild_with_grandparent 106.448 106.448 0 0.000%
communication_grandparent_to_grandchild 101.707 101.707 0 0.000%
communication_parent_to_child 89.814 89.814 0 0.000%
contexts 106.578 106.578 0 0.000%
counter 86.854 86.854 0 0.000%
counter_functional 87.261 87.261 0 0.000%
dyn_create_destroy_apps 89.698 89.698 0 0.000%
file_upload 100.729 100.729 0 0.000%
function_memory_game 173.479 173.479 0 0.000%
function_router 350.678 350.688 +0.010 +0.003%
function_todomvc 162.199 162.199 0 0.000%
futures 230.407 230.407 0 0.000%
game_of_life 111.113 111.113 0 0.000%
immutable 186.091 186.091 0 0.000%
inner_html 80.552 80.552 0 0.000%
js_callback 110.319 110.319 0 0.000%
keyed_list 200.067 200.067 0 0.000%
mount_point 83.447 83.447 0 0.000%
nested_list 114.661 114.661 0 0.000%
node_refs 90.968 90.968 0 0.000%
password_strength 1751.430 1751.430 0 0.000%
portals 94.205 94.205 0 0.000%
router 319.489 319.499 +0.010 +0.003%
simple_ssr 141.331 141.331 0 0.000%
ssr_router 388.894 388.903 +0.010 +0.003%
suspense 116.487 116.487 0 0.000%
timer 89.370 89.370 0 0.000%
timer_functional 98.736 98.736 0 0.000%
todomvc 142.512 142.512 0 0.000%
two_apps 86.571 86.571 0 0.000%
web_worker_fib 135.557 135.557 0 0.000%
web_worker_prime 185.972 185.972 0 0.000%
webgl 83.170 83.170 0 0.000%

✅ None of the examples has changed their size significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant