Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implicit-clone to 0.5.0 #3682

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

cecton
Copy link
Member

@cecton cecton commented Jul 12, 2024

Fixes #3659

Copy link

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.858 ns      │ 3.892 ns      │ 2.879 ns      │ 2.901 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.881 ns      │ 3.041 ns      │ 2.898 ns      │ 2.906 ns      │ 100     │ 1000000000

Copy link

Visit the preview URL for this PR (updated for commit 3198c68):

https://yew-rs-api--pr3682-update-implicit-clon-c6evuhw2.web.app

(expires Fri, 19 Jul 2024 20:14:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.967 314.731 309.704 1.781
Hello World 10 496.143 498.812 497.303 0.841
Function Router 10 1621.998 1644.296 1632.613 7.751
Concurrent Task 10 1005.759 1007.456 1006.473 0.567
Many Providers 10 1111.988 1153.075 1124.116 16.131

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 289.387 290.055 289.634 0.219
Hello World 10 491.149 502.833 497.597 4.703
Function Router 10 1727.884 1741.472 1734.788 4.162
Concurrent Task 10 1005.945 1007.140 1006.577 0.335
Many Providers 10 1148.845 1203.451 1168.856 15.731

Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 97.674 97.678 +0.004 +0.004%
boids 167.802 167.797 -0.005 -0.003%
communication_child_to_parent 90.178 90.180 +0.002 +0.002%
communication_grandchild_with_grandparent 102.414 102.409 -0.005 -0.005%
communication_grandparent_to_grandchild 97.841 97.836 -0.005 -0.005%
communication_parent_to_child 86.543 86.532 -0.011 -0.012%
contexts 101.985 102.001 +0.016 +0.015%
counter 83.181 83.179 -0.002 -0.002%
counter_functional 83.605 83.604 -0.002 -0.002%
dyn_create_destroy_apps 86.534 86.530 -0.004 -0.005%
file_upload 97.581 97.579 -0.002 -0.002%
function_memory_game 163.905 163.895 -0.011 -0.007%
function_router 338.205 338.182 -0.023 -0.007%
function_todomvc 157.891 157.896 +0.005 +0.003%
futures 225.771 225.768 -0.004 -0.002%
game_of_life 105.263 105.260 -0.003 -0.003%
immutable 185.581 185.584 +0.003 +0.002%
inner_html 77.536 77.531 -0.005 -0.006%
js_callback 105.768 105.761 -0.007 -0.006%
keyed_list 195.324 195.320 -0.004 -0.002%
mount_point 80.517 80.516 -0.001 -0.001%
nested_list 111.243 111.240 -0.003 -0.003%
node_refs 87.847 87.847 0 0.000%
password_strength 1711.705 1711.700 -0.005 -0.000%
portals 90.750 90.754 +0.004 +0.004%
router 308.889 308.892 +0.003 +0.001%
simple_ssr 137.718 137.707 -0.011 -0.008%
ssr_router 375.400 375.434 +0.033 +0.009%
suspense 112.069 112.060 -0.010 -0.009%
timer 86.099 86.098 -0.001 -0.001%
timer_functional 94.871 94.862 -0.009 -0.009%
todomvc 139.050 139.050 0 0.000%
two_apps 83.211 83.206 -0.005 -0.006%
web_worker_fib 131.457 131.460 +0.003 +0.002%
web_worker_prime 181.937 181.932 -0.005 -0.003%
webgl 80.214 80.213 -0.001 -0.001%

✅ None of the examples has changed their size significantly.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!

@ranile ranile merged commit 08aef70 into yewstack:master Jul 25, 2024
18 of 23 checks passed
@cecton cecton deleted the update-implicit-clone branch July 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the trait bound implicit_clone::unsync::IMap<_, _>: From<indexmap::IndexMap<K, V>> is not satisfied
3 participants