You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think extend is better both to avoid confusion because the behaviour of your function aligns better with IndexMap::extend than IndexMap::union and also because makes it clearer it works with single (String) values.
Yeah, I'm flip-floping hard on this minor detail. I think extend as the function name with comments for that and push saying that it takes the logical union of the two sets of classes is the best course of action.
Maybe something like this is possible for .new() constructor? Classes::new(&["grid","wrapper","main"])
or Classes::from(&["grid","wrapper","main"])
Imo, it looks a bit easier to work with...
We already have Classes::from("grid wrapper main"), which is effectively what the framework uses when you specify the class attribute inside of the html! macro.
What this PR is targeting is the scenario where you want to pass Classes around as props, but don't want to use format! when you want to conditionally add another class to the set.
626: Add extend method to Classes r=jstarry a=hgzimmerman
Also implement Clone.
Addresses #621
----
I'm a little off-put by the use of `format!()` having to be used to concatenate strings that are later used as classes.
This change allows for usages like:
```rust
html!{
<div class=Classes::new().union("some-class").union("other-class") />
}
```
or
```rust
html!{
<div class=self.class.clone().union("other-class") />
}
```
Co-authored-by: Henry Zimmerman <zimhen7@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also implement Clone.
Addresses #621
I'm a little off-put by the use of
format!()having to be used to concatenate strings that are later used as classes.This change allows for usages like:
or