Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unimplemented message #716

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Conversation

lily-mara
Copy link
Contributor

When calling Bridged::bridge, it is possible to get a confusing
unimplemented error. This PR adds some explanation and clarity around
the error.

When calling Bridged::bridge, it is possible to get a confusing
unimplemented error. This PR adds some explanation and clarity around
the error.
@hgzimmerman
Copy link
Member

I like the idea of this, but am hesitant about linking to a specific version of the documentation, as that is likely to fall out of sync quickly when we bump the version.
I believe that https://docs.rs/yew/latest/yew/agent/index.html will redirect to the newest documentation version, so barring significant reorganization of the project, the link will continue to point at the most relevant documentation without any intervention on our part.

@lily-mara
Copy link
Contributor Author

Does this message look better?

@hgzimmerman
Copy link
Member

Yes, I think its satisfactory. I don't have merge privileges on this repo, so you need to wait for a maintainer with the ability to merge to take a look at this. Sorry for the delay.

@jstarry
Copy link
Member

jstarry commented Nov 3, 2019

@natemara sorry for the delay, can you fix the fmt error that is showing up on the rust stable ci job?

It's pretty unfortunate that you ran into this, the Global agent is not implemented at all yet so I'm not sure why it was added in the first place. If you're interested in using it, here's an issue to tackle if you're up for the task! #283

@jstarry jstarry merged commit 98ebc65 into yewstack:master Nov 11, 2019
llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
* Improve unimplemented message

When calling Bridged::bridge, it is possible to get a confusing
unimplemented error. This PR adds some explanation and clarity around
the error.

* Update link to point to latest

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants