Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building with web-sys #961

Merged
merged 49 commits into from
Feb 29, 2020
Merged

Add support for building with web-sys #961

merged 49 commits into from
Feb 29, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Feb 23, 2020 •
edited
Loading

Fixes #558

Problem

The rust / wasm community has adopted web-sys and js-sys as the foundational crates for building web applications. web-sys is generated from WebIDL specs which ensures it will be both complete and up-to-date. Furthermore, once interface types became a reality, Yew will be better suited to take advantage of the performance gains. Lastly, the future of the stdweb project is uncertain as it hasn't been updated in some time.

Implementation

  • Since wasm-bindgen doesn't support asm.js and emscripten, we have decided to continue supporting stdweb (which does).
  • Now that web-sys and stdweb are both supported, Yew requires users to select which library they would like to use. This is a breaking change and compiler errors will inform developers to choose one.

TODO

  • Lots of merge conflicts with master that need to be resolved (please make PR fixes against web-sys branch rather than pushing to web-sys directly)

This work was spear-headed by @daxpedda 🙇

jstarry and others added 26 commits December 28, 2019 21:19
@jstarry
Enable travis
6357834
@daxpedda @jstarry
web-sys general conversion (#826)
0d29a28 
* Moved patches from different PRs.

* Add bits & pieces and some services.

* Rename `stdweb` feature to `std_web`.

* Move tests and examples to different PR.

* Revert some `cargo_web` handling removal.

* Missed something.

* Implement `console_error_panic_hook`.

* Update Cargo.toml

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
@jstarry
Move document creation to util convenience method (#855)
05bb014
@daxpedda @jstarry
web-sys listener conversion (#813)
7adfef1 
* `web-sys` listener initial try.

* Improve macros?

* Remove generic from `EventListenerHandle`.

* Fix build.

* A cleaner solution?

* Even cleaner.

* Fix `build.rs`.

* Minor improvements.

* Following the yew toml style.

* Fixing visibility.

* Fix `rustfmt`.

* Add `web-sys` re-exports.

* Move general changes to different PR.

* Remove compat.

* Actually remove `compat.rs`.

* Rename `stdweb` feature to `std_web`.

* Move to gloo's `EventListener` and some polish.

* Remove outdated comment.

* Change `EventHandler` to be cancelled on drop.
@daxpedda @jstarry
web-sys html conversion (#817)
2aa747e 
* Converting all `html` parts.

* Format.

* Move general changes to different PR.

* Removed compat.

* Rename `stdweb` feature to `std_web`.

* Remove redudant function copy.

* Some polish.

* Move to gloo's `EventListener`.

* Replace `unwrap`s with `expect`s.
@daxpedda @jstarry
web-sys agent conversion (#818)
d9235d9 
* Converting `agent`.

* Remove wrong `cfg` in imports.

* Move general changes to different PR.

* Some optimisations.

* Rename `stdweb` feature to `std_web`.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Add js module worker.

* Use `cfg-if`` and `cfg-match` to make things clearer.

* Fix `std_web` build.

* Add some polish.
@jstarry
Merge branch 'master' into web-sys
437db52
@jstarry
Merge branch 'master' into web-sys
3fde267
@jstarry
Add build guards for invalid build configs (#866)
8bb9d88
@daxpedda @jstarry
web_sys cfg conversion (#862)
3b3fa96 
* Use `cfg-if` and `cfg-match` and some polish.

* Mistakes were made.

* Missed line during rebasing.

* Mistakes were undone.

* Remove global.

* Remove part of `global!`.
@daxpedda @jstarry
web-sys services conversion (#827)
c1f621a 
* Convert `console`.

* Finish services.

* Some polish.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Fix aborting fetch leading to error and some polish.

* Replaced some `unwrap`s with `expect`s.

* Use `cfg_if` and `cfg_match` and do some polish.

* Proper scoping.

* Some fixes.

* Move fetch and reader services to different PR.

* Revert split.
@jstarry
Merge branch 'master' into web-sys
c85fd29
@jstarry
Fix CI builds (#877)
74fbc2c
@jstarry
Merge branch 'master' into web-sys
317376a
@jstarry
Fix derive_props_test
ab2d91d
@jstarry
Move tests (#897) (#898)
045f54d
@daxpedda @jstarry
web-sys fetch service conversion (#867)
047ad2a 
* Split implementation.

* Import global.

* Import global.

* Revert split.

* Make fetch available again.

* Revert "Revert split."

This reverts commit 6e3f101.

* Re-revert split.

* Some polish.

* Move to `wasm_bindgen_futures`.

* Switch to `thiserror`.

* wip

* Update src/services/fetch/web_sys.rs

Co-Authored-By: daxpedda <daxpedda@gmail.com>

* Some more polish.

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
@daxpedda @jstarry
web-sys reader service conversion (#868)
e4762ca 
* Split reader implementation.

* Revert split.

* Remove leftover files.

* Make reader available again.

* Revert "Revert split."

This reverts commit 8abdc9c.

* Revert "Remove leftover files."

This reverts commit 188c6eb.

* Re-revert split.

* Polish.

* Forgot some part.

* Some polish.

* Some polish.
@daxpedda @jstarry
web-sys examples/tests conversion (#841)
1cc57ce 
* Fix examples/tests to work with `web_sys`.

* Update `StorageService` usage.

* Split `stdweb` and `web-sys` examples.

* Fixing the shell script.

* Trying to reset file permissions.

* Update to new reader API.

* Update to new fetch API.

* Update to new fetch API.

* Re-enable examples CI.

* Deleted duplicate example.

* Some fixes.

* Fix rand build.
@daxpedda
Fix spawning workers in combination with wasm-bindgen. (#901)
0ed0241
@jstarry
Fix component rendering process (#913)
ecf79b2 
* wip

* Fix component rendering process
@jplatte @jstarry
Simplify yew-macro a bit (#902)
9e603ce 
* yew-macro: Simplify Properties validation

* Fix most clippy warnings
@jstarry
Fix clippy warnings (#912)
ac4b697
@jstarry
Import Task trait in dashboard example
49d4f10
@jstarry
Remove duplicate vtag tests
e1f6768
@jetli
Fix prevent_default() by non-passive (#958)
f6fe1e0 
* Fix prevent_default() by non-passive

* Fix cargo fmt
@jstarry jstarry changed the title Web sys Add support for building with web-sys Feb 23, 2020
daxpedda and others added 19 commits February 25, 2020 20:35
@daxpedda
Merge commit 'd1180c0369edfc6f19f539a448e6d9bdfeb1a077' into web-sys-…
bd43d37 
…fixes
@daxpedda
Merge commit '063c25472efcc79c017eecd73da9fbd062aa3550' into web-sys-…
05a0854 
…fixes
@daxpedda
Merge commit 'c422a5ed1b4f82f986b3293c465eb825ea72a656' into web-sys-…
a2152aa 
…fixes
@daxpedda
Merge commit '3dca0c775869f5bb28e00acbba2f97d5af1aa8f5' into web-sys-…
2c6e8c7 
…fixes
@daxpedda
Merge commit 'ee4792c7f6350962afd9e605b6c1c09731ed4c9c' into web-sys-…
86a4a77 
…fixes
@daxpedda
Remove Option from resize service.
84e2802
@daxpedda
Merge commit 'aedce8bfbcdaaadc815fd4c01a65d36eb43a6ce1' into web-sys-…
b0639f4 
…fixes
@daxpedda
Merge commit '87f76f7736cb8c063ff291e99d43d1941c4509e4' into web-sys-…
07da4ed 
…fixes
@daxpedda
Merge commit '839b793b17241783d60d4bd25acb2c41599b2081' into web-sys-…
05ff2ce 
…fixes
@daxpedda
Merge commit '1ede16795a8f08975708e1808c0d528f31d5c946' into web-sys-…
2cb6ae9 
…fixes
@daxpedda
Merge commit '12da2b5119abbaa17e1b2ce88740f650d035284a' into web-sys-…
7019d20 
…fixes
@daxpedda
Apply fetch changes.
2ce21b7
@daxpedda
Merge commit 'df14a9fc3e74c697e1e5e201f35fd177b83065ae' into web-sys-…
c69c370 
…fixes
@daxpedda
Apply reader service changes.
8b7ab86
@daxpedda
Merge commit 'a5e74e7d1dd42362abb902b13498911c269841cc' into web-sys-…
7ebf37e 
…fixes
@daxpedda
Merge commit 'b534a4c83a3f4dabcfa39ddf582515091a6539dd' into web-sys-…
2a9fb99 
…fixes
@daxpedda
Merge commit '6a759329d1a5a49d062e6265b1435f8dff54c6f4' into web-sys-…
8fddbab 
…fixes
@daxpedda
Fix node_refs example.
4790b33
@jstarry
Merge pull request #966 from daxpedda/web-sys-fixes
4b43e24 
web-sys master merge
@daxpedda daxpedda mentioned this pull request Feb 26, 2020
Merged
@jstarry jstarry merged commit d38ce42 into master Feb 29, 2020
@jstarry
Copy link
Member Author

jstarry commented Feb 29, 2020

I squashed it 😮

AlephAlpha pushed a commit to AlephAlpha/yew that referenced this pull request Feb 29, 2020
@jstarry @daxpedda
@jplatte @jetli @AlephAlpha
Add support for building with web-sys (yewstack#961)
29b90f5 
* Enable travis

* `web-sys` general conversion (yewstack#826)

* Moved patches from different PRs.

* Add bits & pieces and some services.

* Rename `stdweb` feature to `std_web`.

* Move tests and examples to different PR.

* Revert some `cargo_web` handling removal.

* Missed something.

* Implement `console_error_panic_hook`.

* Update Cargo.toml

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Move document creation to util convenience method (yewstack#855)

* `web-sys` listener conversion (yewstack#813)

* `web-sys` listener initial try.

* Improve macros?

* Remove generic from `EventListenerHandle`.

* Fix build.

* A cleaner solution?

* Even cleaner.

* Fix `build.rs`.

* Minor improvements.

* Following the yew toml style.

* Fixing visibility.

* Fix `rustfmt`.

* Add `web-sys` re-exports.

* Move general changes to different PR.

* Remove compat.

* Actually remove `compat.rs`.

* Rename `stdweb` feature to `std_web`.

* Move to gloo's `EventListener` and some polish.

* Remove outdated comment.

* Change `EventHandler` to be cancelled on drop.

* `web-sys` html conversion (yewstack#817)

* Converting all `html` parts.

* Format.

* Move general changes to different PR.

* Removed compat.

* Rename `stdweb` feature to `std_web`.

* Remove redudant function copy.

* Some polish.

* Move to gloo's `EventListener`.

* Replace `unwrap`s with `expect`s.

* `web-sys` agent conversion (yewstack#818)

* Converting `agent`.

* Remove wrong `cfg` in imports.

* Move general changes to different PR.

* Some optimisations.

* Rename `stdweb` feature to `std_web`.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Add js module worker.

* Use `cfg-if`` and `cfg-match` to make things clearer.

* Fix `std_web` build.

* Add some polish.

* Add build guards for invalid build configs (yewstack#866)

* `web_sys` cfg conversion (yewstack#862)

* Use `cfg-if` and `cfg-match` and some polish.

* Mistakes were made.

* Missed line during rebasing.

* Mistakes were undone.

* Remove global.

* Remove part of `global!`.

* `web-sys` services conversion (yewstack#827)

* Convert `console`.

* Finish services.

* Some polish.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Fix aborting fetch leading to error and some polish.

* Replaced some `unwrap`s with `expect`s.

* Use `cfg_if` and `cfg_match` and do some polish.

* Proper scoping.

* Some fixes.

* Move fetch and reader services to different PR.

* Revert split.

* Fix CI builds (yewstack#877)

* Fix derive_props_test

* Move tests (yewstack#897) (yewstack#898)

* `web-sys` fetch service conversion (yewstack#867)

* Split implementation.

* Import global.

* Import global.

* Revert split.

* Make fetch available again.

* Revert "Revert split."

This reverts commit 6e3f101.

* Re-revert split.

* Some polish.

* Move to `wasm_bindgen_futures`.

* Switch to `thiserror`.

* wip

* Update src/services/fetch/web_sys.rs

Co-Authored-By: daxpedda <daxpedda@gmail.com>

* Some more polish.

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* `web-sys` reader service conversion (yewstack#868)

* Split reader implementation.

* Revert split.

* Remove leftover files.

* Make reader available again.

* Revert "Revert split."

This reverts commit 8abdc9c.

* Revert "Remove leftover files."

This reverts commit 188c6eb.

* Re-revert split.

* Polish.

* Forgot some part.

* Some polish.

* Some polish.

* `web-sys` examples/tests conversion (yewstack#841)

* Fix examples/tests to work with `web_sys`.

* Update `StorageService` usage.

* Split `stdweb` and `web-sys` examples.

* Fixing the shell script.

* Trying to reset file permissions.

* Update to new reader API.

* Update to new fetch API.

* Update to new fetch API.

* Re-enable examples CI.

* Deleted duplicate example.

* Some fixes.

* Fix rand build.

* Fix spawning workers in combination with `wasm-bindgen`. (yewstack#901)

* Fix component rendering process (yewstack#913)

* wip

* Fix component rendering process

* Simplify yew-macro a bit (yewstack#902)

* yew-macro: Simplify Properties validation

* Fix most clippy warnings

* Fix clippy warnings (yewstack#912)

* Import Task trait in dashboard example

* Remove duplicate vtag tests

* Fix prevent_default() by non-passive (yewstack#958)

* Fix prevent_default() by non-passive

* Fix cargo fmt

* Remove `Option` from most services.

* Remove `Option` from resize service.

* Apply fetch changes.

* Apply reader service changes.

* Fix `node_refs` example.

* Remove web-sys travis branch

Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>
jstarry added a commit that referenced this pull request Mar 1, 2020
@AlephAlpha @jstarry
@daxpedda @jplatte @jetli
Properties 2.0 (#975)
afb5e9d 
* Properties 2.0

* Fix problem when passing a closure to prop_or_else

* Update test names

* Add support for building with web-sys (#961)

* Enable travis

* `web-sys` general conversion (#826)

* Moved patches from different PRs.

* Add bits & pieces and some services.

* Rename `stdweb` feature to `std_web`.

* Move tests and examples to different PR.

* Revert some `cargo_web` handling removal.

* Missed something.

* Implement `console_error_panic_hook`.

* Update Cargo.toml

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Move document creation to util convenience method (#855)

* `web-sys` listener conversion (#813)

* `web-sys` listener initial try.

* Improve macros?

* Remove generic from `EventListenerHandle`.

* Fix build.

* A cleaner solution?

* Even cleaner.

* Fix `build.rs`.

* Minor improvements.

* Following the yew toml style.

* Fixing visibility.

* Fix `rustfmt`.

* Add `web-sys` re-exports.

* Move general changes to different PR.

* Remove compat.

* Actually remove `compat.rs`.

* Rename `stdweb` feature to `std_web`.

* Move to gloo's `EventListener` and some polish.

* Remove outdated comment.

* Change `EventHandler` to be cancelled on drop.

* `web-sys` html conversion (#817)

* Converting all `html` parts.

* Format.

* Move general changes to different PR.

* Removed compat.

* Rename `stdweb` feature to `std_web`.

* Remove redudant function copy.

* Some polish.

* Move to gloo's `EventListener`.

* Replace `unwrap`s with `expect`s.

* `web-sys` agent conversion (#818)

* Converting `agent`.

* Remove wrong `cfg` in imports.

* Move general changes to different PR.

* Some optimisations.

* Rename `stdweb` feature to `std_web`.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Add js module worker.

* Use `cfg-if`` and `cfg-match` to make things clearer.

* Fix `std_web` build.

* Add some polish.

* Add build guards for invalid build configs (#866)

* `web_sys` cfg conversion (#862)

* Use `cfg-if` and `cfg-match` and some polish.

* Mistakes were made.

* Missed line during rebasing.

* Mistakes were undone.

* Remove global.

* Remove part of `global!`.

* `web-sys` services conversion (#827)

* Convert `console`.

* Finish services.

* Some polish.

* Fix `ArrayBuffer` to `Uint8Array` conversions.

* Fix aborting fetch leading to error and some polish.

* Replaced some `unwrap`s with `expect`s.

* Use `cfg_if` and `cfg_match` and do some polish.

* Proper scoping.

* Some fixes.

* Move fetch and reader services to different PR.

* Revert split.

* Fix CI builds (#877)

* Fix derive_props_test

* Move tests (#897) (#898)

* `web-sys` fetch service conversion (#867)

* Split implementation.

* Import global.

* Import global.

* Revert split.

* Make fetch available again.

* Revert "Revert split."

This reverts commit 6e3f101.

* Re-revert split.

* Some polish.

* Move to `wasm_bindgen_futures`.

* Switch to `thiserror`.

* wip

* Update src/services/fetch/web_sys.rs

Co-Authored-By: daxpedda <daxpedda@gmail.com>

* Some more polish.

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* `web-sys` reader service conversion (#868)

* Split reader implementation.

* Revert split.

* Remove leftover files.

* Make reader available again.

* Revert "Revert split."

This reverts commit 8abdc9c.

* Revert "Remove leftover files."

This reverts commit 188c6eb.

* Re-revert split.

* Polish.

* Forgot some part.

* Some polish.

* Some polish.

* `web-sys` examples/tests conversion (#841)

* Fix examples/tests to work with `web_sys`.

* Update `StorageService` usage.

* Split `stdweb` and `web-sys` examples.

* Fixing the shell script.

* Trying to reset file permissions.

* Update to new reader API.

* Update to new fetch API.

* Update to new fetch API.

* Re-enable examples CI.

* Deleted duplicate example.

* Some fixes.

* Fix rand build.

* Fix spawning workers in combination with `wasm-bindgen`. (#901)

* Fix component rendering process (#913)

* wip

* Fix component rendering process

* Simplify yew-macro a bit (#902)

* yew-macro: Simplify Properties validation

* Fix most clippy warnings

* Fix clippy warnings (#912)

* Import Task trait in dashboard example

* Remove duplicate vtag tests

* Fix prevent_default() by non-passive (#958)

* Fix prevent_default() by non-passive

* Fix cargo fmt

* Remove `Option` from most services.

* Remove `Option` from resize service.

* Apply fetch changes.

* Apply reader service changes.

* Fix `node_refs` example.

* Remove web-sys travis branch

Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>

* Fix vtag test warning (#978)

* Clean up exported apis and doc visibility (#977)

* Clean up exported apis and doc visibility

* Remove unused ScopeHolder

* Change ComponentLink to alias of Scope

* cargo fmt

* update new examples to Properties 2.0

* Fix a mistake when resolving conflicts

* Remove an outdated hack.

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>
@jstarry jstarry deleted the web-sys branch June 20, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using wasm-bindgen, build with js-sys and web-sys
4 participants
@jstarry @daxpedda @jplatte @jetli