add checks to fail combined-coverage tests after each part (#346)

Currently tests are failing silently in Github actions. This PR adds checks to combined-coverage.sh script to exit if a test fails. The three tests currently failing on main will now be caught, I created this item to handle them separately, as it will require a change to make react versions to test programmable in reusable workflows

J=SLAP-2459
TEST=manual

ran actions with an intentional failure (log). Also commented out npm publish from the slap publish command and tested that it makes it passed the check there

package.json

@@ -42,7 +42,7 @@
     "storybook": "start-storybook -p 6006",
     "build-storybook": "build-storybook",
     "wcag": "test-storybook",
-    "test:unit": "jest --coverage --coverageDirectory=coverage/unit",
+    "test:unit": "jest",
     "test:visual": "./tests/scripts/visual-coverage.sh",
     "test": "./tests/scripts/combined-coverage.sh"
   },
@@ -100,11 +100,12 @@
   "jest": {
     "bail": 0,
     "verbose": true,
-    "collectCoverage": false,
+    "collectCoverage": true,
     "collectCoverageFrom": [
       "src/**",
       "!src/models/**"
     ],
+    "coverageDirectory": "coverage/unit",
     "moduleFileExtensions": [
       "js",
       "ts",

tests/scripts/combined-coverage.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
-npm run test:unit
-npm run test:visual
+npm run test:unit || exit 1
+npm run test:visual || exit 1
 
 # merge
 mkdir -p coverage/merge