Fix imports for commonly-named components #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes imports for commonly-named components like
Container
andText
by manually writing their imports to the file before callingts-morph
sfixMissingImports
function. Previously, this function would often add an incorrect import in the case ofContainer
and not add any import in the case ofText
, which is also a built-in interface in React.J=SLAP-2587
TEST=auto, manual
Added
postcss
to the test site and saw that without these changes,Container
was imported frompostcss
(which also has a named export calledContainer
), and that with these changes,Container
is correctly imported fromsrc/components
. Also saw that the behavior forText
was fixed (i.e. an import was actually added for aText
component rather than it trying to use the React type).