Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiteSettingsFile #64

Merged
merged 20 commits into from
Dec 15, 2022
Merged

SiteSettingsFile #64

merged 20 commits into from
Dec 15, 2022

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Dec 13, 2022 •
edited
Loading

This PR adds SiteSettingsFile for parsing SiteSettings, and refactors shared code so that it can be used for SiteSettingsFile.

Notably StudioSourceFile's parseDefaultExport -> getDefaultExport, will now return the default export node without trying to further parse it if it's an identifier, and will return the ArrayLiteralExpression or ObjectLiteralExpression since SiteSettings can use an ObjectLiteralExpression.

J=SLAP-2517
TEST=auto

@oshi97 oshi97 requested a review from a team December 13, 2022 22:48
@oshi97 oshi97 requested review from yen-tt and nmanu1 December 14, 2022 20:21
nmanu1
nmanu1 reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be another item to add writing to file for site settings?

@oshi97
Copy link
Contributor Author

oshi97 commented Dec 15, 2022

will there be another item to add writing to file for site settings?

Yeah I can make a separate item

@oshi97 oshi97 requested review from nmanu1 and yen-tt December 15, 2022 15:32
@tmeyer2115 tmeyer2115 self-requested a review December 15, 2022 15:35
@oshi97 oshi97 merged commit 6467ba2 into main Dec 15, 2022
@oshi97 oshi97 deleted the dev/site-settings branch December 15, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeyer2115 tmeyer2115 tmeyer2115 approved these changes

@nmanu1 nmanu1 Awaiting requested review from nmanu1

@yen-tt yen-tt Awaiting requested review from yen-tt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshi97 @tmeyer2115 @yen-tt @nmanu1