fix: Improve field type translation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every subclass of the listed basic types is assumed to be meant to be translated to the corresponding SQLAlchemy types. Adds support for the Boolean, Date and DateTime types, fixes an issue where e.g. ConstrainedInt would be translated to JSON type. Since this changes the database type for some python types, it might break code or lead to unexpected results when regenerating tables that were first created before this change.
Codecov ReportBase: 100.00% // Head: 99.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
===========================================
- Coverage 100.00% 99.43% -0.57%
===========================================
Files 20 20
Lines 702 709 +7
===========================================
+ Hits 702 705 +3
- Misses 0 4 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Haven't been able to rewrite the tests yet, sorry for that. A little explanation why I chose to use issubclass() nearly everywhere:
|
yezz123
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Amazing work @iron3oxide 🚀 ! I fix the Linting issue and I add some tests for both the Bool case and the Date/DateTime case it looks good overall 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every subclass of the listed basic types is assumed to be meant to be translated to the corresponding SQLAlchemy types. Adds support for the Boolean, Date and DateTime types, fixes an issue where e.g. ConstrainedInt would be translated to JSON type, see #43 .
Since this changes the database type for some python types, it might break code or lead to unexpected results when regenerating tables that were first created before this change.