Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change warning to notice #46

Merged
merged 2 commits into from
Jun 16, 2024
Merged

change warning to notice #46

merged 2 commits into from
Jun 16, 2024

Conversation

Vanley
Copy link
Contributor

@Vanley Vanley commented Jun 14, 2024

When not specified uv version, annotation should just inform about it.
Potentially will solve #31

Available annotations on the github actions (https://github.com/actions/toolkit/tree/main/packages/core):

image

yezz123
yezz123 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Owner

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it will not solve this issue #31, but that's great. I guess noticing it is much better than raising a warning.

Thanks, @Vanley 🚀

@yezz123 yezz123 merged commit ce75db7 into yezz123:main Jun 16, 2024
32 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vanley @yezz123