Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #288, @mrcljx pointed out that characters in link URLs that are already escaped get escaped again. For example:
is encoded as
This PR removes implicit encoding from link URLs. Following @yhatt's recommendation, it ensures we continue to escape characters that Slack reserves.
&
,<
, and>
are replaced by corresponding HTML entities, and we continue to useurlEncode
to escape|
.closes #288