Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fill country #654

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat: fill country #654

merged 4 commits into from
Apr 15, 2024

Conversation

ben-29
Copy link
Collaborator

@ben-29 ben-29 commented Apr 14, 2024

We have a layer for filling provinces. In this PR, I introduced a new layer for filling countries. This feature is only suitable for Chinese users.

The world GeoJSON utilizes the package @surbowl/world-geo-json-zh.

preview of yihong data:
image
preview of jeff:
image

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 7:54am

@yihong0618
Copy link
Owner

LGTM

@yihong0618 yihong0618 merged commit e7eec7c into yihong0618:master Apr 15, 2024
6 checks passed
ben-29 added a commit to ben-29/workouts_page that referenced this pull request Apr 21, 2024
* refs/heads/upstream:
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)

# Conflicts:
#	README-CN.md
#	README.md
#	pnpm-lock.yaml
#	src/components/Layout/style.module.scss
#	src/components/LocationStat/index.tsx
#	src/components/RunMap/index.tsx
#	src/components/RunMap/style.module.css
#	src/components/RunTable/RunRow.tsx
#	src/components/SVGStat/index.tsx
#	src/components/YearStat/index.tsx
#	src/styles/variables.scss
#	src/utils/const.ts
#	src/utils/utils.ts
chensoul added a commit to chensoul/running_page that referenced this pull request Apr 26, 2024
* yihong0618-master: (33 commits)
  Fix codoon and Upload tcx_to_garmin (yihong0618#662)
  Update README-CN.md (yihong0618#663)
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)
  chore: Update package manager and ignore requirements-dev.txt (yihong0618#632)
  add run.drink.cafe (yihong0618#628)
  feat: coros sync (yihong0618#623)
  Fix README typo (yihong0618#624)
  fix: ts type error (yihong0618#622)
  ...
ben-29 added a commit to ben-29/workouts_page that referenced this pull request May 26, 2024
* refs/heads/upstream: (71 commits)
  Add laqieer's running page to README (yihong0618#672)
  chore: add raycast extension support (yihong0618#670)
  add </details> (yihong0618#669)
  fix the deprecation warning (yihong0618#668)
  Fix codoon and Upload tcx_to_garmin (yihong0618#662)
  Update README-CN.md (yihong0618#663)
  add keep2strava (yihong0618#653)
  Add data to 'running page runners' table (yihong0618#656)
  style: use Tailwind CSS (yihong0618#655)
  feat: fill country (yihong0618#654)
  docs: add runner (yihong0618#651)
  doc: add new runner
  docs: update README (yihong0618#650)
  docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644)
  fix: no package manager
  fix: tachyons-sass import error (yihong0618#639)
  Update README.md (yihong0618#638)
  Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634)
  chore: fix typo (yihong0618#633)
  chore: Update package manager and ignore requirements-dev.txt (yihong0618#632)
  ...

# Conflicts:
#	run_page/gpxtrackposter/track.py
#	run_page/keep_sync.py
Kugin pushed a commit to Kugin/running_page that referenced this pull request Sep 13, 2024
* feat: add line color in China Geojson

* feat: fill countries that been there; only support Chinese user;

* feat: fill countries that been there; only support Chinese user;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants