Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow 'ani.res' option to work in 'saveVideo()' #129

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix: Allow 'ani.res' option to work in 'saveVideo()' #129

merged 1 commit into from
Sep 24, 2020

Conversation

trevorld
Copy link
Contributor

@trevorld trevorld commented Sep 7, 2020 •
edited
Loading

  • This is basically the same fix for 'saveVideo()' that I recently did for 'saveHTML()' which in turn was copied from 'saveGIF()'
  • This should fix Resolution in saveVideo #125

@yihui yihui requested a review from yulijia September 8, 2020 02:00
yulijia
yulijia approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@yulijia yulijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed reply, I have checked this code, well done.
Thanks a lot!

@yulijia yulijia merged commit a6355a1 into yihui:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulijia yulijia yulijia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolution in saveVideo
2 participants
@trevorld @yulijia