fix: Support 'ani.res' for arbitrary graphic devices #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for 'ani.res' for arbitrary graphic devices
in 'saveGIF()', 'saveHTML()', and 'saveVideo()'.
* Should work for any graphic device function with 'res'
as an argument. In particular should continue to support R's built-in
raster image format devices as well as 'ragg::agg_png()'
and R's built-in devices passed in as a function instead of string.
* Still no 'ani.res' support in 'saveLatex()' ('pdf' devices recommended)
nor 'saveSWF()' (flash no longer supported in many browsers)
* Also fixes bug when 'ani.dev' is a function instead of a character vector
closes #133, closes #134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 'saveGIF()', 'saveHTML()', and 'saveVideo()'.
as an argument. In particular should continue to support R's built-in
raster image format devices passed as strings as well as now supporting 'ragg::agg_png()'
and R's built-in devices passed in as a function instead of string.
nor 'saveSWF()' (flash no longer supported in many browsers)
closes #134