fix yihui/xaringan#307: don't add a div around the sql table output

yihui · Mar 18, 2022 · fb54231 · fb54231
1 parent d919733
commit fb54231
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: knitr
 Type: Package
 Title: A General-Purpose Package for Dynamic Report Generation in R
-Version: 1.37.6
+Version: 1.37.7
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),
     person("Abhraneel", "Sarma", role = "ctb"),

diff --git a/R/engine.R b/R/engine.R
@@ -664,7 +664,8 @@ eng_sql = function(options) {
         display_data[[1]] = as.character(first_column)
 
       # wrap html output in a div so special styling can be applied
-      if (is_html_output()) cat('<div class="knitsql-table">\n')
+      add_div = is_html_output() && is.null(getOption('xaringan.format'))
+      if (add_div) cat('<div class="knitsql-table">\n')
 
       # determine records caption
       caption = options$tab.cap
@@ -684,7 +685,7 @@ eng_sql = function(options) {
       print(kable(display_data, caption = caption))
 
       # terminate div
-      if (is_html_output()) cat("\n</div>\n")
+      if (add_div) cat("\n</div>\n")
 
       # otherwise use tibble if it's available
     } else if (loadable('tibble')) {