Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts_current locking in 1.44 is breaking JuliaCall #2295

Closed
2 tasks
cderv opened this issue Sep 28, 2023 · 7 comments · Fixed by #2296
Closed
2 tasks

opts_current locking in 1.44 is breaking JuliaCall #2295

cderv opened this issue Sep 28, 2023 · 7 comments · Fixed by #2296
Assignees
Labels
next Issues/PRs considered for the next release

Comments

@cderv
Copy link
Collaborator

cderv commented Sep 28, 2023

@yihui Just to track this in order to help them solve this as for now CRAN version of Julia does not work with knitr 1.44 when plots.

it came up in

JuliaCall is using opts_current$set, so they need to update but it seems they did not see problem yet.
https://github.com/Non-Contradiction/JuliaCall/blob/c05473bea78a0197c639f7e82ab1c6f2e943e1cc/R/RMarkdown.R#L56C1-L60

It seems there is a stale maintenance question though there...

So hopefully we can help.

@yihui
Copy link
Owner

yihui commented Sep 29, 2023

I tend to change the error to warning for now.

@yihui yihui linked a pull request Oct 10, 2023 that will close this issue
@yihui yihui assigned yihui and cderv Oct 10, 2023
yihui added a commit that referenced this issue Oct 10, 2023
…king (#2296)

Co-authored-by: Yihui Xie <xie@yihui.name>
@github-project-automation github-project-automation bot moved this from To discuss / To plan to Done in R Markdown Team Projects Oct 10, 2023
@bschneidr
Copy link

Perhaps knitr could rely on JuliaConnectoR instead of JuliaCall?

https://cran.r-project.org/web/packages/JuliaConnectoR/index.html

JuliaCall doesn't seem to be actively maintained, whereas JuliaConnectoR is actively maintained and seems much better documented (for example, it now has a detailed JSS paper).

@yihui
Copy link
Owner

yihui commented Feb 19, 2024

@bschneidr The status of JuliaCall is indeed a little concerning, but the nice thing is this: https://github.com/Non-Contradiction/JuliaCall/blob/master/R/RMarkdown.R i.e., it has provided an engine function that can be set via knitr::knit_engine$set(). If JuliaConnectoR also provides such a function, I'll be happy to support it on knitr's side. Thank you!

@cderv
Copy link
Collaborator Author

cderv commented Feb 19, 2024

@bschneidr I would advise opening an issue at https://github.com/stefan-m-lenz/JuliaConnectoR for a julia engine for knitr.

We can then chime in if help is needed for that. Thank you !

Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
@cderv
Copy link
Collaborator Author

cderv commented Dec 5, 2024

Upstream has been fixed :
JuliaInterop/JuliaCall@a6147cb

@yihui
Copy link
Owner

yihui commented Dec 5, 2024

Great! Thanks for the heads up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
next Issues/PRs considered for the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants