Cache the result of SQL chunk properly #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the original author of this idea is @yihui: yihui#1542 (review)
yihui
reviewed
May 10, 2018
|
Here you are! BTW, "(thanks, @..., #...)" at the end seems the format, but I feel a bit weird to say thanks to myself... lol |
|
I guess it will be even more weird to |
|
Thanks! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The original author of this idea is @yihui: #1542 (review))
fixes rstudio/rmarkdown#914
When the engine is not R and the result of R object exists, the object should be passed to
block_cache; SQL chunk and Stan chunk are the cases. Currently, Stan chunk does the right thing. This PR also make the result of SQL chunk to be cached.