Add flags to ffmpeg mp4 hook for Safari support #1586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current ffmpeg mp4 converter setup in knitr in-line
animation, I was not able to have my animations show up in
Safari. After adding the flags in this commit, it worked.
https://apple.stackexchange.com/questions/166553/why-wont-video-from-ffmpeg-show-in-quicktime-imovie-or-quick-preview
I found the Safari viewability to be sensitive to exactly where
the flags were placed. For instance, running
ffmpeg -y -r 1 -pix_fmt yuv420p -i foo-%d.png foo.mp4
did not work, otherwise I would consider aliasing my ffmpeg
command. It turned out to be necessary to include the -i flag
first, as so:
ffmpeg -y -r 1 -i foo-%d.png -pix_fmt yuv420p foo.mp4