Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Generic Engine #1829

Closed
wants to merge 2 commits into from
Closed

Conversation

TianyiShi2001
Copy link

@TianyiShi2001 TianyiShi2001 commented Apr 4, 2020

A generic engine that make it possible to run any language using custom commands.

Screenshot 2020-04-05 at 05 58 48

This is just a quick-and-dirty implementation (from conception to implementation in one night). If you find this interesting, please post your comments here so I can go ahead and add more features/make it more robust.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like the idea of providing a generic engine to run arbitrary commands. There are a couple of issues with the current implementation, but I don't have time at the moment to mention all of them. I'll revisit this PR in a few weeks. The main problem in my eyes is the templating syntax {}, which may not be robust or flexible. I'd probably consider using sprintf() and %s. Thank you!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cderv cderv mentioned this pull request Dec 9, 2020
yihui added a commit that referenced this pull request Nov 15, 2021
yihui added a commit to yihui/knitr-examples that referenced this pull request Jan 13, 2022
@yihui yihui closed this in #2073 Jan 13, 2022
yihui added a commit that referenced this pull request Jan 13, 2022
close #1829 and close #1833

Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
@yihui
Copy link
Owner

yihui commented Jan 13, 2022

Hi @TianyiShi2001, I want to let you know that we have just provided a generic engine for executing commands, and you can find the documentation and examples at https://github.com/yihui/knitr-examples/blob/master/124-exec-engine.Rmd. Please feel free to let us know if you have any suggestions or comments. Many thanks for your original idea!

@yihui yihui mentioned this pull request Jan 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants