Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ragg png device #1834

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Support for ragg png device #1834

merged 3 commits into from
Apr 18, 2020

Conversation

cpsievert
Copy link
Contributor

@csgillespie
Copy link
Contributor

Neat! It's probably worth adding the other ragg devices as well, such as jpeg? Also, should ragg be added to Suggests?

@cpsievert
Copy link
Contributor Author

should ragg be added to Suggests?

It shouldn't be necessary...FWIW, Cairo and svglite are also not in suggests

yihui
yihui approved these changes Apr 17, 2020
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also add a NEWS item? Thank you!

@cpsievert
Copy link
Contributor Author

@yihui done in 8f5b81a

@yihui yihui merged commit 9b46506 into yihui:master Apr 18, 2020
yihui added a commit that referenced this pull request Apr 21, 2020
@yihui
suggest ragg (amend #1834)
84daff3
@cderv cderv mentioned this pull request May 6, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpsievert @csgillespie @yihui