issue with fig.keep
: don't try to remove figures if all should be kept
#1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using
fig.keep
with index vector it could happen. This should fix #1579I took the opportunity of this PR to
rearrange_figs()
to apply then logic previously inblock_exec()
About the unit test, it took me some times to understand the plot logic with
recorderplot
and low level plot. I believe I got it right, but you set in the start of the test filewhich is unset with
options(op)
a bit afterSo I am unsure if I can use plot functions below this. It seems to work though.
Last step would have been a refactoring between files as I think it could be interested to have all the plot related function in a file
plot.R
like the test files.That is for another time.