Change cache.extra to be a per chunk option #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes cache.extra to the be a per chunk option rather than a package option. This allows you to set a particular chunk's cache to be invalidated if the modification time of the file is updated for instance, among numerous other uses. The previous behavior can still be used by specifying the cache.extra chunk option in the first chunk to make it the default, as with the regular cache option. Fixes yihui#404
|
I think this makes sense and will accept it tomorrow. Thanks! |
|
Is there anything else you would like changed with this pull request before accepting it yihui? |
|
No, I leave it open just to remind myself to update the website accordingly. |
yihui
added a commit
that referenced
this pull request
Oct 25, 2012
Change cache.extra to be a per chunk option (fixed #404)
| @@ -53,7 +53,7 @@ call_block = function(block) { | |||
| # Check cache | |||
| if (params$cache) { | |||
| content = list(params[setdiff(names(params), 'include')], getOption('width')) | |||
| content[[3L]] = eval_lang(opts_knit$get('cache.extra')) | |||
| content[[3L]] = eval_lang(opts_chunk$get('cache.extra')) | |||
There was a problem hiding this comment.
as a matter of fact, this line is no longer necessary because all chunk options have been evaluated before, including cache.extra
yihui
added a commit
that referenced
this pull request
Oct 25, 2012
yihui
added a commit
that referenced
this pull request
Oct 25, 2012
yihui
added a commit
that referenced
this pull request
Oct 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes cache.extra to the be a per chunk option rather than a package option.
This allows you to set a particular chunk's cache to be invalidated if the
modification time of the file is updated for instance, among numerous other
uses. The previous behavior can still be used by specifying the cache.extra
chunk option in the first chunk to make it the default, as with the regular
cache option. Fixes #404