Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chunk option: cache.rebuild #995

Merged
merged 4 commits into from
Apr 19, 2015
Merged

New chunk option: cache.rebuild #995

merged 4 commits into from
Apr 19, 2015

Conversation

zachary-foster
Copy link
Contributor

From documentation (pull request #996):

cache.rebuild: (FALSE) if TRUE, the chunk is evaluated even if cache=TRUE
and no changes are made. This is useful when given an R code argument.
For example: cache.rebuild=!file.exists("path/to/file.ext")
(see #238).

I had a bit of trouble understanding everything that was going on in the code, but I think I got the gist of it. I basically used the idea that when cache.rebuild = TRUE, the code for loading and running the chunk would proceed as if the cache did not exist, but the parts of the code that saves the cache would remain unaffected. I tested this a couple different ways and it seems to accomplish the goal of #238, but I cant guarantee its free of side effects without a greater understanding of the code. I can do some more rigorous testing, but it might help if you could point me towards some things it might break. Thanks!

@yihui
Copy link
Owner

yihui commented Apr 18, 2015

This looks perfect. Could you squash the four commits commits into one? https://github.com/yihui/knitr/blob/master/CONTRIBUTING.md#pull-requests Thanks!

@yihui
Copy link
Owner

yihui commented Apr 18, 2015

@yihui yihui merged commit 5719bfc into yihui:master Apr 19, 2015
@yihui yihui added this to the v1.10 milestone Apr 19, 2015
yihui added a commit that referenced this pull request Apr 19, 2015
@yihui
Copy link
Owner

yihui commented Apr 19, 2015

Due to the large amount of changes this weekend, it might be confusing for you to resolve the conflicts, so I just went ahead and merged the PR. Thanks!

@zachary-foster
Copy link
Contributor Author

Thanks! I have been away from my computer for a few days. I forgot to look
for the contribution guidelines but i will follow them in the future.

Zach

On Sunday, April 19, 2015, Yihui Xie notifications@github.com wrote:

Due to the large amount of changes this weekend, it might be confusing for
you to resolve the conflicts, so I just went ahead and merged the PR.
Thanks!


Reply to this email directly or view it on GitHub
#995 (comment).

Zachary S.L. Foster, PhD Student
Oregon State University
USDA Agricultural Research Service
Horticultural Crops Research Lab
Corvallis, Oregon, USA
http://grunwaldlab.cgrb.oregonstate.edu/

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants