Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Schema::$typeMap to constant Schema::TYPE_MAP #312

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 16, 2023

The change reduces size of cache.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e83366) 99.04% compared to head (4ceadd6) 99.04%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      174      174           
=========================================
  Files            13       13           
  Lines           524      524           
=========================================
  Hits            519      519           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Transformation of 'typeMap' property into a constant
    The code now utilizes a permanent and unchangeable value, referred to as TYPE_MAP, replacing the formerly used variable typeMap. This ensures more stability and predictability in the code.

  • Updated references to use the new 'TYPE_MAP' constant
    All previous reference points in the code where typeMap was used have now been revised to utilize the new constant TYPE_MAP.

  • Added documentation for the 'TYPE_MAP' constant
    A new commentary section known as a 'docblock' has been written for TYPE_MAP to provide further information and context for this constant.

  • 'TYPE_MAP' constant employed in column type assignments
    The code employed for assigning types to columns within our databases now refers to the TYPE_MAP constant. This ensures a more standardized and coherent approach to defining column types.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 16, 2023
@vjik vjik merged commit b7bcc2b into master Nov 16, 2023
40 checks passed
@vjik vjik deleted the change-typemap-to-constant branch November 16, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants