Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pretty name of closures on PHP 8.4 #96

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

staabm
Copy link

@staabm staabm commented May 25, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

related to php/php-src#13550

see analog symfony change: symfony/symfony#54614

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (3215a38) to head (5b700c7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master      #96      +/-   ##
=============================================
- Coverage     100.00%   96.17%   -3.83%     
  Complexity        89       89              
=============================================
  Files              3        3              
  Lines            211      209       -2     
=============================================
- Hits             211      201      -10     
- Misses             0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk
Copy link
Member

Need to add a test with PHP 8.4

@staabm
Copy link
Author

staabm commented May 25, 2024

@vjik vjik added the status:under development Someone is working on a pull request. label May 25, 2024
@samdark samdark self-requested a review July 7, 2024 07:48
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need test with PHP 8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants