Add Config and Migration, Update Adapter.php #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aphraoh
commented
Mar 28, 2024
aphraoh
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
========================================
Coverage 0.00% 0.00%
- Complexity 22 28 +6
========================================
Files 1 2 +1
Lines 84 112 +28
========================================
- Misses 84 112 +28 ☔ View full report in Codecov by Sentry. |
|
@vjik could you please merge this one too. Thanx |
xepozz
requested changes
Apr 1, 2024
vjik
reviewed
Apr 2, 2024
config/di.php
Outdated
There was a problem hiding this comment.
You can remove configuration with empty array.
There was a problem hiding this comment.
Hi @vjik, when I do that there is issues either with composer update or something else, I can not remember what it was or why, can we leave it for now?
Co-authored-by: Dmitriy Derepko <xepozz@list.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.