Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug classes and add more tests #224

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix debug classes and add more tests #224

merged 3 commits into from
Nov 9, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 8, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@vjik vjik added the status:code review The pull request needs review. label Nov 8, 2023
@vjik vjik requested a review from a team November 8, 2023 10:51
Copy link

what-the-diff bot commented Nov 8, 2023

PR Summary

  • Addition of 'enabledMiddlewares' property
    A new property 'enabledMiddlewares' is introduced and utilized in the DebugRoutesCommand file.
  • Removal of 'codeCoverageIgnore' annotation
    'codeCoverageIgnore' annotation, earlier used in DebugRoutesCommand.php, RouterCollector.php, and UrlMatcherInterfaceProxy.php has been removed. This indicates a modification concerning the coverage of code during testing.
  • Introduction of DebugRoutesCommand tests
    New test files - DebugRoutesCommandTest.php has been introduced with multiple test methods. These methods would test various functionalities of DebugRoutesCommand including its function for a specific route, its base functionality, etc.
  • Tests for RouterCollector
    Two new tests have been added to check the functioning of RouterCollector when 'CurrentRoute' and 'RouteCollection' are not available.
  • Testing and Stubbing of UrlMatcherInterfaceProxy
    A new test file, UrlMatcherInterfaceProxyTest.php, has been introduced for testing the UrlMatcherInterfaceProxy. Additionally, the UrlMatcherStub class has been created to assist in testing implementation by acting as a stand-in for this class.

@vjik vjik merged commit 0892cbe into master Nov 9, 2023
22 of 26 checks passed
@vjik vjik deleted the debug-tests branch November 9, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants