Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from 3.x to master #239

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Merge changes from 3.x to master #239

merged 3 commits into from
Feb 20, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 20, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

vjik added 2 commits February 20, 2024 14:50
#	.github/workflows/rector.yml
#	composer-require-checker.json
#	composer.json
Copy link

what-the-diff bot commented Feb 20, 2024

PR Summary

  • Removal of Scrutinizer Configuration File
    The .scrutinizer.yml file, used for managing a tool that scrutinizes code, was removed as it's no longer needed.

  • Updates to Several GitHub Workflow Files
    The .github/workflows files saw several changes to improve the management of code build and checks:

    • The bc.yml, build.yml, composer-require-checker.yml have new configurations to better manage when these workflows should be triggered.
    • In build.yml and rector.yml, a key setting for PHP (the programming language used in this project) has been updated in the phpunit job, which tests the code.
    • Updates were made to the mutation.yml and rector.yml files, to use an updated version of PHP, improving the security and performance of the code checking process.
  • Revised Changelog and Readme Files
    Updates were made to CHANGELOG.md and README.md:

    • CHANGELOG.md now includes information about the new release and its changes, giving users a clear view of what's new.
    • README.md had links to code quality and coverage badges updated for better transparency of code quality. Additionally, old badges related to scrutinizer tool, which has been phased out, were removed.
  • Dependency Version Updates in Composer.json
    In composer.json, which manages our project's software dependencies, versions for rector/rector and vimeo/psalm were updated. This ensures our project uses the latest and most secure versions of these integral tools.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2954c4) 95.66% compared to head (5bab384) 97.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #239      +/-   ##
============================================
+ Coverage     95.66%   97.40%   +1.73%     
  Complexity      181      181              
============================================
  Files            16       16              
  Lines           577      577              
============================================
+ Hits            552      562      +10     
+ Misses           25       15      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team February 20, 2024 11:54
@vjik vjik added the status:code review The pull request needs review. label Feb 20, 2024
@vjik vjik merged commit 7b4d133 into master Feb 20, 2024
22 of 24 checks passed
@vjik vjik deleted the merge-3.x branch February 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants