Refactoring Nav widget.
#187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
terabytesoftw
commented
Dec 18, 2024
terabytesoftw
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
…s, headers, links, and text items.
…or the toggle button.
…/yii-bootstrap5 into refactor-dropdown-widget
…/yii-bootstrap5 into refactor-dropdown-widget
…trap5 into refactor-menus
…ing nav links with attributes.
samdark
approved these changes
Dec 18, 2024
vjik
requested changes
Dec 18, 2024
| * | ||
| * @see https://getbootstrap.com/docs/5.3/components/navs-tabs/#horizontal-alignment | ||
| */ | ||
| enum NavStyle: string |
There was a problem hiding this comment.
Split it to:
- alignment (horizontal start, horizontal center, horizontal end),
- style (default, tabs, pills, underline)
- ??? (default, fill, justified) - I don't know how better call this property.
There was a problem hiding this comment.
https://getbootstrap.com/docs/5.3/components/navs-tabs/#available-styles The documentation refers to styles, it seems to me that dividing them makes it more complex.
There was a problem hiding this comment.
Deny combine styles of different types.
There was a problem hiding this comment.
This widget is used to build the menu widgets, and styles are perfect for that purpose, separating them would make it even more difficult, that's why it is structured this way in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.