Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill other processes is port is taken #211

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Kill other processes is port is taken #211

wants to merge 17 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jun 23, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
image

@xepozz xepozz requested a review from a team June 24, 2024 05:54
@xepozz xepozz added the status:code review The pull request needs review. label Jun 24, 2024
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature 👍

Comment on lines +201 to +203
$xDebugEnabled = $isLinux && $xDebugInstalled && $input->hasOption('xdebug') && $input->getOption(
'xdebug'
) === null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$xDebugEnabled = $isLinux && $xDebugInstalled && $input->hasOption('xdebug') && $input->getOption(
'xdebug'
) === null;
$xDebugEnabled = $isLinux
&& $xDebugInstalled
&& $input->hasOption('xdebug')
&& $input->getOption('xdebug') === null;

'ERROR',
'error',
);
if (!$io->confirm('Kill the process', true)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!$io->confirm('Kill the process', true)) {
if (!$io->confirm('Kill the process' . (count($runningCommandPIDs) > 1 ? 'es' : ''), true)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants