Refactor pagination #228
Merged
Refactor pagination #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Nov 28, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fix #222 |
samdark
requested changes
Dec 6, 2024
samdark
approved these changes
Dec 8, 2024
rossaddison
added a commit
to rossaddison/invoice
that referenced
this pull request
Dec 11, 2024
And prepare for Google testing. 3 Clients have been setup i.e Github, Google, and Facebook. These appear on the login form and their client_id's are set in the .env file. None have been tested yet. Return Urls etc. have still to be setup. More indexes have pagination associated with them. Others will have to be updated later.
rossaddison
added a commit
to rossaddison/invoice
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.