Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split yii-debug package codebase #209

Merged
merged 13 commits into from
Apr 29, 2023
Merged

Split yii-debug package codebase #209

merged 13 commits into from
Apr 29, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Mar 26, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️

Moved debug classes close to their packages

@what-the-diff
Copy link

what-the-diff bot commented Mar 26, 2023

PR Summary

  • Removed unnecessary components and classes This includes yiisoft/validator, view, auth, CommandInterfaceProxy, ConnectionInterfaceProxy, DatabaseCollector, TransactionInterfaceDecorator, RouterCollector, UrlMatcherInterfaceProxy, and WebViewCollector.
  • Updated configuration files Changes were made to config/events-web.php, config/params.php, and debug component configuration, including the reordering of collectors.
  • Improved DatabaseCollector method A new parameter was added to the collectQueryStart() method in src/Collector/DatabaseCollector.php.
  • Updated tests in DebuggerServiceProviderFactoryTestTrait New key 'collectors' was added to array $config['debug'] in testGetConfig() and testCreateContainerWithDefaultConfiguration() methods.
  • General clean up This includes removing unused code, fixing typos in the documentation, and removing tests for deleted classes.

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +11.05 🎉

Comparison is base (7bc6a44) 53.73% compared to head (ed385d2) 64.78%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #209       +/-   ##
=============================================
+ Coverage     53.73%   64.78%   +11.05%     
+ Complexity      656      472      -184     
=============================================
  Files            51       34       -17     
  Lines          2075     1471      -604     
=============================================
- Hits           1115      953      -162     
+ Misses          960      518      -442     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good idea.

Copy link
Member

@rustamwin rustamwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xepozz and others added 9 commits March 27, 2023 12:12
# Conflicts:
#	src/Collector/Database/DatabaseCollector.php
#	src/Collector/Queue/QueueCollector.php
#	src/Collector/ValidatorCollector.php
#	src/Collector/Web/AssetCollector.php
#	src/Collector/Web/IdentityCollector.php
#	src/Collector/Web/RouterCollector.php
#	tests/Collector/QueueCollectorTest.php
#	tests/Collector/UserCollectorTest.php
#	tests/Collector/ValidatorInterfaceProxyTest.php
@xepozz xepozz merged commit bace86a into master Apr 29, 2023
@xepozz xepozz deleted the split-debug branch April 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants