Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 compatibility #4553

Merged
merged 9 commits into from
Sep 20, 2024
Merged

PHP 8.3 compatibility #4553

merged 9 commits into from
Sep 20, 2024

Conversation

marcovtwout
Copy link
Member

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #4552

@marcovtwout
Copy link
Member Author

@samdark I ran into an issue with PHP 8.3 and phpunit for tests that use @runInSeparateProcess. Automated tests are failing with:

PHPUnit_Framework_Exception: PHP Notice:  stream_get_contents(): Read of 8192 bytes failed with errno=9 Bad file descriptor in Standard input code on line 59
PHP Stack trace:
PHP   1. {main}() Standard input code:0
PHP   2. __phpunit_run_isolated_test() Standard input code:100
PHP   3. stream_get_contents($stream = resource(2) of type (stream)) Standard input code:59

I applied some local patches for now and the tests are running now, but am not entirely sure they are the definitive solution. Apperantly similar issues were found on Yii2 as well, could you comment on the appropiate solution for yii1?

Related issues:

@marcovtwout marcovtwout requested a review from samdark June 4, 2024 13:13
composer.json Outdated Show resolved Hide resolved
@mlpassos
Copy link

Hey @marcovtwout ,

Thanks for your work on Yii and the PHP community and on this... do we have a date or estimate for releasing this 8.3 compatibility? We are about to test this.. we are already on 8.1 and migrating to 8.3 now.

o//

@samdark
Copy link
Member

samdark commented Sep 18, 2024

@marcovtwout merged compatibility patch.

@marcovtwout marcovtwout marked this pull request as ready for review September 18, 2024 14:51
@marcovtwout marcovtwout requested a review from samdark September 18, 2024 14:51
@marcovtwout marcovtwout merged commit 9d0b1ff into master Sep 20, 2024
26 checks passed
@marcovtwout marcovtwout deleted the php-8.3-compatibility branch September 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants